Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cache): Trigger cacache to remove expired contents #28275

Merged
merged 8 commits into from
Apr 9, 2024

Conversation

gg-kialo
Copy link
Contributor

@gg-kialo gg-kialo commented Apr 8, 2024

Changes

Verify the cacache after removing index entries at the end of a run to remove cache contents on disk.

The existing cacache cleanup is only removing cache entries from the index, not the contents.
This results in the cache contents being forgotten about and continuing to accrue on disk.

Verifying with cacache.verify(...) will garbage collect any content entries not referenced by the index as well as cleaning up corrupted or invalid index entries.

Context

Closes #28169.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

viceice
viceice previously approved these changes Apr 8, 2024
@viceice viceice requested a review from secustor April 8, 2024 16:21
Co-authored-by: Sebastian Poxhofer <[email protected]>
@viceice viceice enabled auto-merge April 9, 2024 09:50
@viceice viceice added this pull request to the merge queue Apr 9, 2024
Merged via the queue into renovatebot:main with commit fcfbf38 Apr 9, 2024
37 checks passed
@gg-kialo gg-kialo deleted the fix/28169-clear-cacache branch April 9, 2024 13:20
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.280.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants