Add RemixBrowser routes prop #9062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f738c2a The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
added
feat:routing
package:server-runtime
renderer:react
feat:spa
brophdawg11
commented
Mar 19, 2024
| if (!route.loader) { | ||
| route = { ...route, loader: hydratingLoader }; | ||
| } | ||
| rootRoute.children.push(route); |
There was a problem hiding this comment.
Add the routes as children of the root route
brophdawg11
commented
Mar 19, 2024
| } else { | ||
| let rootDataRoute = router.routes[0]; | ||
| rootDataRoute.children?.forEach((route) => | ||
| addPropRoutesToRemix(route as DataRouteObject, rootDataRoute.id) |
There was a problem hiding this comment.
Add the routes to window.__remixManifest and window__remixRouteModules
brophdawg11
commented
Mar 19, 2024
| hasErrorBoundary: route.hasErrorBoundary === true, | ||
| imports: [], | ||
| css: [], | ||
| module: undefined, |
There was a problem hiding this comment.
These don't have modules to fetch, so that required some changes elsewhere to make manifestRoute.module an optional field
|
Replaced by remix-run/react-router#11693 in RR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eases the migration path of
RouterProviderto Remix SPA Mode by allowing folks to lift their currentroutesand pass them toRemixBrowserinstead of needing to go to file-based routes (viaroutes/ordefineRoutes)Todo: