Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<HydratedRouter routes> prop #11652

Closed
ryanflorence opened this issue Jun 10, 2024 · 2 comments
Closed

<HydratedRouter routes> prop #11652

ryanflorence opened this issue Jun 10, 2024 · 2 comments
Assignees
Labels

Comments

@ryanflorence
Copy link
Member

remix-run/remix#9062

This enables data routers to incrementally adopt route modules

@brophdawg11
Copy link
Contributor

#11693

@brophdawg11 brophdawg11 linked a pull request Jun 28, 2024 that will close this issue
@brophdawg11 brophdawg11 pinned this issue Jun 28, 2024
@brophdawg11 brophdawg11 unpinned this issue Jun 28, 2024
@brophdawg11
Copy link
Contributor

Chatted with Ryan and we don't actually need/want this since you can't really mix/match these routes with vite file-based routes in any meaningful way.

  • We could patch them into an SSR app but you'd have 404/hydration errors for any client-side only routes
    • Then you also end up having to move entire route subtrees at once - and if you have a root layout route then you need to move everything all at once
  • We could restrict it to SPA apps but you still have to then move everything over before you can use SSR
    • This still has the move a whole subtree at once limitation
  • The RouterProvider routes is essentially what routes.ts will be with lazy -> file so there's no real reason to introduce an intermediate step - we'll just have folks go right to routes.ts
    • They can just move everything to lazy in RouterPRovider
    • Then switch to file and to HydratedRouter

@brophdawg11 brophdawg11 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants