Add new rook subscription #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
Nikhil-Ladha
force-pushed
the
add-rook-subscription
branch
3 times, most recently
from
07e0d8b to
6ac3814
Compare
iamniting
requested changes
Mar 13, 2024
iamniting
requested changes
Mar 13, 2024
iamniting
requested changes
Mar 13, 2024
Nikhil-Ladha
force-pushed
the
add-rook-subscription
branch
from
6ac3814 to
6e12e78
Compare
|
Tested the changes and everything is working fine |
|
/unhold |
iamniting
requested changes
Mar 14, 2024
Add rook-ceph-operator subscription to odf-operator Also, update the odf-catalogsource to include rook-ceph-operator bundle in it. Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
add-rook-subscription
branch
from
6e12e78 to
e2e1a46
Compare
This was referenced Mar 18, 2024
|
@Nikhil-Ladha We also need some changes in the e2e tests. |
iamniting
requested changes
Mar 18, 2024
Update e2e tests to include rook subscription and rook csv while installing odf-operator Signed-off-by: Nikhil-Ladha <[email protected]>
Nikhil-Ladha
force-pushed
the
add-rook-subscription
branch
from
4311e1c to
5df17e7
Compare
|
/retest |
|
/test odf-operator-e2e-aws |
|
/retest |
|
/test odf-operator-e2e-aws |
|
/retest |
|
/test odf-operator-e2e-aws |
iamniting
approved these changes
Mar 19, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit b3d8c5a
into
red-hat-storage:main
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added rook-ceph-operator subscription to odf-operator Also, updated the odf-catalogsource to include rook-ceph-operator bundle in it.