bundle: add ocs-client-operator as olm dependency #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iamniting wrt CI failure
|
Bundle image should be pullable |
iamniting
requested changes
Mar 18, 2024
leelavg
force-pushed
the
install-client-dep
branch
from
219e890 to
2cf145d
Compare
|
I'm able to build catalog w/o any issues, should CI be retrigerred? |
iamniting
requested changes
Mar 22, 2024
|
/test odf-operator-e2e-aws |
leelavg
force-pushed
the
install-client-dep
branch
from
2cf145d to
593e8ab
Compare
|
@ezio-auditore could you pls take a look at first commit in this PR, let me know if the prom starting csv isn't an intentional miss. thanks. |
Ran below commands from
red-hat-storage/ocs-client-operator/tree/release-4.15 (ff31e31) and
resulting images/values are used in this commit.
export CLUSTER_ENV=openshift
export VERSION=4.15.0
export IMG=quay.io/ocs-dev/ocs-client-operator:v${VERSION}
export OCS_CLIENT_CONSOLE_IMG=\
quay.io/ocs-dev/ocs-client-console:v${VERSION}
export CSI_ADDONS_PACKAGE_VERSION=0.7.0
export BUNDLE_IMG=quay.io/ocs-dev/ocs-client-operator-bundle:v${VERSION}
make container-build container-push
make bundle-build bundle-push
Signed-off-by: Leela Venkaiah G <[email protected]>
Update e2e tests for deploying ocs-client subscription and csv while installing odf-operator Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
install-client-dep
branch
from
593e8ab to
461b72b
Compare
|
|
Testing: |
|
/test odf-operator-e2e-aws |
nb-ohad
requested changes
Mar 22, 2024
Comment on lines
+11
to
+13
| value: | ||
| packageName: ocs-client-operator | ||
| version: ">=4.14.0 <4.15.0 || 4.15.0" |
There was a problem hiding this comment.
@leelavg Wouldn't this create issues for us when it comes to updating the client via the desired channel mechanism?
There was a problem hiding this comment.
Due to earlier work w/ operator condition odf-operator update itself will not get triggered if there will be unsupported clients.
So, native client-op subscription to be managed by odf-op is a safe operation and it should not create any issue w/ webhook.
|
/test odf-operator-e2e-aws |
iamniting
approved these changes
Mar 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, leelavg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit f3575bb
into
red-hat-storage:main
16 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install ocs-client-operator as a dependency of odf-operator and we don't need to manage the subscription since ocs-client-operator channel name changes will go through a webhook will be dployed by ocs-client-operator itself.
part of [RHSTOR-5487]