bundle: Modify the name and reference of the sample storagesystem

[iamniting]

In certain instances customers unintentionally create two storagesystems to the same storagecluster. This becomes problematic when attempting to delete one storagesystem, as it triggers the deletion of the associated storagecluster. By changing the name and reference, we aim to prevent this issue from occurring.

It will make sure that even if they create the storagesystem from the OCP console it wont refer to the same storagecluster.

Signed-off-by: Nitin Goyal [email protected]

Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2263441
https://bugzilla.redhat.com/show_bug.cgi?id=2254343

[umangachapagain]

This is avoiding the problem and not actually fixing it.
Nothing stops me from creating 2 StorageSystems pointing to the same StorageCluster.

I see 2 options for a complete fix:

1. Admission webhook to reject such requests immediately.
2. Validate that StorageCluster does not already have a different owner before taking it's ownership. Current behavior of owning the StorageCluster without validation is a bug.

[umangachapagain]

We will add more fixes as a follow-up. This is a good start.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, umangachapagain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [iamniting]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iamniting]

/cherry-pick release-4.15

[openshift-cherrypick-robot]

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/cherry-pick release-4.13

[openshift-cherrypick-robot]

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/cherry-pick release-4.12

[openshift-cherrypick-robot]

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[iamniting]

/cherry-pick release-4.11

[openshift-cherrypick-robot]

@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@iamniting: #370 failed to apply on top of branch "release-4.12":

Applying: bundle: Modify the name and reference of the sample storagesystem
Using index info to reconstruct a base tree...
M	bundle/manifests/odf-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging bundle/manifests/odf-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/odf-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bundle: Modify the name and reference of the sample storagesystem
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@iamniting: #370 failed to apply on top of branch "release-4.11":

Applying: bundle: Modify the name and reference of the sample storagesystem
Using index info to reconstruct a base tree...
M	bundle/manifests/odf-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging bundle/manifests/odf-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/odf-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bundle: Modify the name and reference of the sample storagesystem
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@iamniting: new pull request created: #371

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@iamniting: #370 failed to apply on top of branch "release-4.14":

Applying: bundle: Modify the name and reference of the sample storagesystem
Using index info to reconstruct a base tree...
M	bundle/manifests/odf-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging bundle/manifests/odf-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/odf-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bundle: Modify the name and reference of the sample storagesystem
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-cherrypick-robot]

@iamniting: #370 failed to apply on top of branch "release-4.13":

Applying: bundle: Modify the name and reference of the sample storagesystem
Using index info to reconstruct a base tree...
M	bundle/manifests/odf-operator.clusterserviceversion.yaml
Falling back to patching base and 3-way merge...
Auto-merging bundle/manifests/odf-operator.clusterserviceversion.yaml
CONFLICT (content): Merge conflict in bundle/manifests/odf-operator.clusterserviceversion.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 bundle: Modify the name and reference of the sample storagesystem
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.