Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2263473:[release-4.14] bundle: Modify the name and reference of the sample storagesystem #372

Merged

Conversation

iamniting
Copy link
Member

This is an manual cherry-pick of #370

Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@iamniting: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.14] bundle: Modify the name and reference of the sample storagesystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@iamniting iamniting changed the title [release-4.14] bundle: Modify the name and reference of the sample storagesystem Bug 2263473:[release-4.14] bundle: Modify the name and reference of the sample storagesystem Feb 9, 2024
Copy link
Contributor

openshift-ci bot commented Feb 9, 2024

@iamniting: This pull request references Bugzilla bug 2263473, which is invalid:

  • expected the bug to target the "ODF 4.14.5" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2263473:[release-4.14] bundle: Modify the name and reference of the sample storagesystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

In certain instances customers unintentionally create two storagesystems
to the same storagecluster. This becomes problematic when attempting to
delete one storagesystem, as it triggers the deletion of the associated
storagecluster. By changing the name and reference, we aim to prevent
this issue from occurring.

It will make sure that even if they create the storagesystem from the
OCP console it wont refer to the same storagecluster.

Signed-off-by: Nitin Goyal <[email protected]>
@iamniting
Copy link
Member Author

/bugzilla refresh
/hold

Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@iamniting: This pull request references Bugzilla bug 2263473, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.10) matches configured target release for branch (ODF 4.14.10)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh
/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting
Copy link
Member Author

/bugzilla refresh
/unhold

Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@iamniting: This pull request references Bugzilla bug 2263473, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.14.10) matches configured target release for branch (ODF 4.14.10)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla ([email protected]), skipping review request.

In response to this:

/bugzilla refresh
/unhold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2024
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 914e5a9 into red-hat-storage:release-4.14 Jul 25, 2024
14 checks passed
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@iamniting: All pull requests linked via external trackers have merged:

Bugzilla bug 2263473 has been moved to the MODIFIED state.

In response to this:

Bug 2263473:[release-4.14] bundle: Modify the name and reference of the sample storagesystem

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting iamniting deleted the release-4.14 branch July 25, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants