Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use updated method for sending client name during heartbeat #134

Closed
wants to merge 9 commits into from

Conversation

leelavg
Copy link
Contributor

@leelavg leelavg commented Apr 5, 2024

Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: leelavg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

github-actions bot commented Apr 5, 2024

This PR/issue depends on:

@leelavg
Copy link
Contributor Author

leelavg commented Apr 5, 2024

only review last commit.

@leelavg
Copy link
Contributor Author

leelavg commented Apr 8, 2024

/hold

for dependencies & custom go.mod replace.

@leelavg
Copy link
Contributor Author

leelavg commented Apr 17, 2024

actual change from this PR is only and clubbed in #136 due to update in Proto and can't be a separate PR.

diff --git a/service/status-report/main.go b/service/status-report/main.go
index 9cacd29..5d62f59 100644
--- a/service/status-report/main.go
+++ b/service/status-report/main.go
@@ -163,7 +163,7 @@ func main() {
                SetOperatorVersion(oprVersion).
                SetClusterID(string(clusterID)).
                SetClusterName(clusterName).
-               SetNamespacedName(storageClientName)
+               SetClientName(storageClientName)
        statusResponse, err := providerClient.ReportStatus(ctx, storageClient.Status.ConsumerID, status)
        if err != nil {
                klog.Exitf("Failed to report status of storageClient %v: %v", storageClient.Status.ConsumerID, err)

@leelavg leelavg closed this Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant