make storageclient api to clusterscope resource #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reviewing on per commit basis will be good. /hold testing in progress as this needs changes at provider end as well to test. |
This was referenced Apr 5, 2024
Merged
nb-ohad
requested changes
Apr 7, 2024
leelavg
force-pushed
the
scl-clusterscope
branch
from
5631944
to
7a14a0d
Compare
|
/hold There's one more point in my saved notes around claim deletion, will be posting that commit soon. |
|
/unhold |
leelavg
force-pushed
the
scl-clusterscope
branch
from
2454f7f
to
3e47d32
Compare
|
fixed commit lint. |
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
scl-clusterscope
branch
3 times, most recently
from
3bdf9ef
to
bd6beef
Compare
nb-ohad
requested changes
Apr 17, 2024
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
scl-clusterscope
branch
from
bd6beef
to
ab89e87
Compare
nb-ohad
requested changes
Apr 17, 2024
Signed-off-by: Leela Venkaiah G <[email protected]>
leelavg
force-pushed
the
scl-clusterscope
branch
from
ab89e87
to
c893ec3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: leelavg, nb-ohad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 05917a6
into
red-hat-storage:main
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as of now storageclient api is namespaced w/ no known benefits that could outweigh ease of operations performed in controllers if it can be cluster scoped.
this PR makes storageclient to clusterscope and majorly benefits from existing tracking of clusterscoped resource (storageclaim) by namespaced resource (existing storageclient) replaced w/ owner references.
design wise, no two storageclient even if namespaced shouldn't be allowed to connect to single provider and as such storageclient better be clusterscoped and only con is for user to choose explicit names to avoid collision and that'd be less of an issue when compared to all the plumbing that is being done in controllers as of now.