Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Parser] Remove SmartPhpParserFactory and SmartPhpParser #6651

Merged
merged 2 commits into from
Jan 6, 2025
Merged

[Parser] Remove SmartPhpParserFactory and SmartPhpParser #6651

merged 2 commits into from
Jan 6, 2025

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jan 6, 2025 •
edited
Loading

  • SmartPhpParserFactory is never used anywhere, so can be removed to have less maintenance internal SimpleParser usage
  • SmartPhpParser use similar functionality with RectorParser, so use RectorParser instead.

@samsonasik samsonasik force-pushed the remove-smart-parser branch from 0e43bcb to 8f80db2 Compare January 6, 2025 07:38
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@samsonasik
Copy link
Member Author

@TomasVotruba let's merge this 👍

@samsonasik samsonasik merged commit 532b39d into main Jan 6, 2025
41 checks passed
@samsonasik samsonasik deleted the remove-smart-parser branch January 6, 2025 10:18
@TomasVotruba
Copy link
Member

Looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba