[Parser] Remove SmartPhpParserFactory and SmartPhpParser

rectorphp · Jan 6, 2025 · 0e43bcb · 0e43bcb
1 parent 2e82ab4
commit 0e43bcb
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 99 deletions.
diff --git a/.github/workflows/code_analysis.yaml b/.github/workflows/code_analysis.yaml
@@ -40,7 +40,7 @@ jobs:
                     -
                         name: 'Active Classes'
                         run: |
-                            vendor/bin/class-leak check bin config src rules utils --skip-suffix "Rector" --skip-type="Rector\\Utils\\Compiler\\Unprefixer" --skip-type="Rector\\PhpDocParser\\PhpParser\\SmartPhpParserFactory" --skip-type="Rector\\NodeCollector\\BinaryOpConditionsCollector" --skip-type="Rector\\Set\\Contract\\SetListInterface"
+                            vendor/bin/class-leak check bin config src rules utils --skip-suffix "Rector" --skip-type="Rector\\Utils\\Compiler\\Unprefixer" --skip-type="Rector\\NodeCollector\\BinaryOpConditionsCollector" --skip-type="Rector\\Set\\Contract\\SetListInterface"
 
                     -
                         name: 'Compatible PHPStan versions'

diff --git a/phpstan.neon b/phpstan.neon
@@ -156,10 +156,6 @@ parameters:
             message:  '#@\\ini_set\(.*\)" is forbidden to use#'
             path: bin/rector.php
 
-        -
-            message: '#Creating new PHPStan\\Parser\\(CachedParser|SimpleParser) is not covered by backward compatibility promise\. The class might change in a minor PHPStan version#'
-            path: src/PhpDocParser/PhpParser/SmartPhpParserFactory.php
-
         # known existing class
         -
             message: '#Instead of "instanceof/is_a\(\)" use ReflectionProvider service or "\(new ObjectType\(<desired_type>\)\)\->isSuperTypeOf\(<element_type>\)" for static reflection to work#'

diff --git a/src/PhpDocParser/PhpParser/SmartPhpParser.php b/src/PhpDocParser/PhpParser/SmartPhpParser.php
diff --git a/src/PhpDocParser/PhpParser/SmartPhpParserFactory.php b/src/PhpDocParser/PhpParser/SmartPhpParserFactory.php
diff --git a/src/PhpParser/AstResolver.php b/src/PhpParser/AstResolver.php
@@ -33,6 +33,7 @@
 use Rector\NodeTypeResolver\NodeTypeResolver;
 use Rector\PhpDocParser\PhpParser\SmartPhpParser;
 use Rector\PhpParser\Node\BetterNodeFinder;
+use Rector\PhpParser\Parser\RectorParser;
 use Rector\Reflection\MethodReflectionResolver;
 use Rector\StaticTypeMapper\Resolver\ClassNameFromObjectTypeResolver;
 use Rector\ValueObject\MethodName;
@@ -53,7 +54,7 @@ final class AstResolver
     private array $parsedFileNodes = [];
 
     public function __construct(
-        private readonly SmartPhpParser $smartPhpParser,
+        private readonly RectorParser $rectorParser,
         private readonly NodeScopeAndMetadataDecorator $nodeScopeAndMetadataDecorator,
         private readonly NodeNameResolver $nodeNameResolver,
         private readonly ReflectionProvider $reflectionProvider,
@@ -306,7 +307,7 @@ public function parseFileNameToDecoratedNodes(?string $fileName): array
         }
 
         try {
-            $stmts = $this->smartPhpParser->parseFile($fileName);
+            $stmts = $this->rectorParser->parseFile($fileName);
         } catch (Throwable $throwable) {
             /**
              * phpstan.phar contains jetbrains/phpstorm-stubs which the code is not downgraded