Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(download): change download filename convention #1392

Closed
wants to merge 1 commit into from
Closed

refact(download): change download filename convention #1392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions app/src/main/java/com/lagradost/cloudstream3/utils/VideoDownloadManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1593,16 +1593,16 @@ object VideoDownloadManager {
return sanitizeFilename(
if (epName == null) {
if (season != null) {
"${context.getString(R.string.season)} $season ${context.getString(R.string.episode)} $episode"
"${context.getString(R.string.season)}$season${context.getString(R.string.episode)}$episode"
} else {
"${context.getString(R.string.episode)} $episode"
"${context.getString(R.string.episode)}$episode"
}
} else {
if (episode != null) {
if (season != null) {
"${context.getString(R.string.season)} $season ${context.getString(R.string.episode)} $episode - $epName"
"${context.getString(R.string.season)}$season${context.getString(R.string.episode)}$episode - $epName"
} else {
"${context.getString(R.string.episode)} $episode - $epName"
"${context.getString(R.string.episode)}$episode - $epName"
}
} else {
epName
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,10 +294,10 @@
<string name="acra_report_toast">Sorry, the application crashed. An anonymous bug report will be sent to the
developers
</string>
<string name="season">Season</string>
<string name="season">S</string>
<string name="season_format">%1$s %2$d%3$s</string>
<string name="no_season">No Season</string>
<string name="episode">Episode</string>
<string name="episode">E</string>
Copy link
Contributor

@CranberrySoup CranberrySoup Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would impact all other uses of this in the app (result UI and player UI), when changing things it is preferable to only change what you intend or need to change, otherwise it will introduce bugs or unwanted behavior. This change would also only affect English users and changed translations are less likely to be fixed than non-existing translations.

You are looking for episode_short and season_short, which already exists and is translated in other languages already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I don't quite understand this with translation and strings. Can you explain this more? I will watch episode_short

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand. Thank you for pointing out these mistakes

<string name="episodes">Episodes</string>
<string name="episodes_range">%1$d-%2$d</string>
<string name="episode_format" formatted="true">%1$d %2$s</string>
Expand Down