Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact(download): change download filename convention #1392

Conversation

int3debug
Copy link
Contributor

reducing filename length for clarity

<string name="season_format">%1$s %2$d%3$s</string>
<string name="no_season">No Season</string>
<string name="episode">Episode</string>
<string name="episode">E</string>
Copy link
Contributor

@CranberrySoup CranberrySoup Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change would impact all other uses of this in the app (result UI and player UI), when changing things it is preferable to only change what you intend or need to change, otherwise it will introduce bugs or unwanted behavior. This change would also only affect English users and changed translations are less likely to be fixed than non-existing translations.

You are looking for episode_short and season_short, which already exists and is translated in other languages already.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I don't quite understand this with translation and strings. Can you explain this more? I will watch episode_short

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I understand. Thank you for pointing out these mistakes

@fire-light42
Copy link
Collaborator

Close due to stale.

@int3debug
Copy link
Contributor Author

int3debug commented Dec 29, 2024

Close due to stale.

What is the expiration date? Unfortunately I haven't had time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants