Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(run-manager): call shutdown endpoint before workflow stop (#559) #559

Merged
merged 3 commits into from
Feb 1, 2024
Merged

feat(run-manager): call shutdown endpoint before workflow stop (#559) #559

merged 3 commits into from
Feb 1, 2024

Commits on Jan 30, 2024

  1. refactor(consumer): do not update status of jobs (reanahub#559) 

    Let reana-job-controller update the status of jobs, as this is not a
concern of reana-workflow-controller, which should manage workflows and
not jobs.
    @mdonadoni
    mdonadoni committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    5992034 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. feat(manager): call shutdown endpoint before workflow stop (reanahub#559 

    )

Call the shutdown endpoint of reana-job-controller before stopping a
running workflow, so that running jobs are correctly cleaned up.

Closes reanahub#252
Closes reanahub#546
    @mdonadoni
    mdonadoni committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    719fa37 View commit details
    Browse the repository at this point in the history

  2. fix(manager): graceful shutdown of job-controller (reanahub#559) 

    Use exec to execute job-controller, so that the server can receive
signals such as `SIGTERM`.

Closes reanahub/reana-job-controller#347
    @mdonadoni
    mdonadoni committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    817b019 View commit details
    Browse the repository at this point in the history