feat(run-manager): call shutdown endpoint before workflow stop (#559) #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
changed the title
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 23, 2024
…hub#559) Call the shutdown endpoint of reana-job-controller before stopping a running workflow, so that running jobs are correctly cleaned up. Closes reanahub#252 Closes reanahub#546
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 23, 2024
Use exec to execute job-controller, so that the server can receive signals such as `SIGTERM`. Closes reanahub/reana-job-controller#347
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
c62df14
to
3093528
Compare
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 23, 2024
…hub#559) Call the shutdown endpoint of reana-job-controller before stopping a running workflow, so that running jobs are correctly cleaned up. Closes reanahub#252 Closes reanahub#546
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 23, 2024
Use exec to execute job-controller, so that the server can receive signals such as `SIGTERM`. Closes reanahub/reana-job-controller#347
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
3093528
to
a1c3498
Compare
giuseppe-steduto
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Nice and clean approach! I was wondering whether we should increase the
termination grace period to be more sure that the HTTP call is completed, but I guess what really matters is that the request is sent to /shutdown. Then even if the response is not delivered in time to the run-batch pod (because the grace period has passed), the jobs should have terminated anyway.
As for the commit scopes, maybe it's better to always use run-manager rather than workflow-run-manager?
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 29, 2024
…b#559) Let reana-job-controller update the status of jobs, as this is not a concern of reana-workflow-controller, which should manage workflows and not jobs.
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 29, 2024
…hub#559) Call the shutdown endpoint of reana-job-controller before stopping a running workflow, so that running jobs are correctly cleaned up. Closes reanahub#252 Closes reanahub#546
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 29, 2024
Use exec to execute job-controller, so that the server can receive signals such as `SIGTERM`. Closes reanahub/reana-job-controller#347
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 29, 2024
Let reana-job-controller update the status of jobs, as this is not a concern of reana-workflow-controller, which should manage workflows and not jobs.
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 29, 2024
…hub#559) Call the shutdown endpoint of reana-job-controller before stopping a running workflow, so that running jobs are correctly cleaned up. Closes reanahub#252 Closes reanahub#546
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 29, 2024
Use exec to execute job-controller, so that the server can receive signals such as `SIGTERM`. Closes reanahub/reana-job-controller#347
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
a1c3498
to
f54d951
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #559 +/- ##
==========================================
+ Coverage 72.50% 72.83% +0.33%
==========================================
Files 15 15
Lines 1382 1362 -20
==========================================
- Hits 1002 992 -10
+ Misses 380 370 -10
|
Let reana-job-controller update the status of jobs, as this is not a concern of reana-workflow-controller, which should manage workflows and not jobs.
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 30, 2024
…hub#559) Call the shutdown endpoint of reana-job-controller before stopping a running workflow, so that running jobs are correctly cleaned up. Closes reanahub#252 Closes reanahub#546
mdonadoni
added a commit
to mdonadoni/reana-workflow-controller
that referenced
this pull request
Jan 30, 2024
Use exec to execute job-controller, so that the server can receive signals such as `SIGTERM`. Closes reanahub/reana-job-controller#347
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
f54d951
to
139728c
Compare
) Call the shutdown endpoint of reana-job-controller before stopping a running workflow, so that running jobs are correctly cleaned up. Closes reanahub#252 Closes reanahub#546
Use exec to execute job-controller, so that the server can receive signals such as `SIGTERM`. Closes reanahub/reana-job-controller#347
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
139728c
to
817b019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #252
Closes #546
Closes reanahub/reana-job-controller#347