Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(python): drop support for Python 3.6 and 3.7 (#683) #683

Merged
merged 1 commit into from
Jul 17, 2024
Merged

build(python): drop support for Python 3.6 and 3.7 (#683) #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: "3.8"

- name: Check Python code formatting
run: |
Expand All @@ -71,7 +71,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: "3.8"

- name: Check compliance with pep8, pyflakes and circular complexity
run: |
Expand All @@ -87,7 +87,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: "3.8"

- name: Check compliance with Python docstring conventions
run: |
Expand All @@ -103,7 +103,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: "3.8"

- name: Check Python manifest completeness
run: |
Expand All @@ -119,7 +119,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: "3.8"

- name: Install system dependencies
run: |
Expand All @@ -136,14 +136,15 @@ jobs:

python-tests:
runs-on: ubuntu-20.04

steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: 3.8
python-version: "3.8"

- name: Install Python dependencies
run: |
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@
],
},
include_package_data=True,
python_requires=">=3.8",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like other components, what to do with python_requires and classifiers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See reanahub/reana-db#235 (comment)

I have kept only Python 3.8 in setup.py's classifiers and in the CI for non-shared components, and Python 3.8-3.12 for the shared ones (reana-db, reana-commons, reana-client, pytest-reana)

extras_require=extras_require,
install_requires=install_requires,
setup_requires=setup_requires,
Expand Down
Loading