build(python): drop support for Python 3.6 and 3.7 (#683) #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
commented
Mar 26, 2024
| @@ -140,6 +140,7 @@ | |||
| }, | |||
| include_package_data=True, | |||
| extras_require=extras_require, | |||
| python_requires=">=3.8", | |||
There was a problem hiding this comment.
Like other components, what to do with python_requires and classifiers?
There was a problem hiding this comment.
See reanahub/reana-db#235 (comment)
I have kept only Python 3.8 in
setup.py's classifiers and in the CI for non-shared components, and Python 3.8-3.12 for the shared ones (reana-db, reana-commons, reana-client, pytest-reana)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #683 +/- ##
==========================================
- Coverage 60.14% 59.46% -0.69%
==========================================
Files 32 32
Lines 3317 3298 -19
==========================================
- Hits 1995 1961 -34
- Misses 1322 1337 +15 |
mdonadoni
added a commit
to mdonadoni/reana-server
that referenced
this pull request
Mar 26, 2024
BREAKING CHANGE: drop support for Python 3.6 and 3.7 Closes reanahub/reana#784
mdonadoni
force-pushed
the
drop-python-36-37
branch
from
306e342
to
3a9f000
Compare
BREAKING CHANGE: drop support for Python 3.6 and 3.7 Closes reanahub/reana#784
mdonadoni
force-pushed
the
drop-python-36-37
branch
from
3a9f000
to
868dee9
Compare
wirespecter
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: drop support for Python 3.6 and 3.7
Closes reanahub/reana#784