Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kn/asymmetric object allow non embedded links #1402

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

nielsenko
Copy link
Contributor

@nielsenko nielsenko commented Sep 15, 2023

  • Lift link restriction on asymmetric objects

Fixes: #1403

@cla-bot cla-bot bot added the cla: yes label Sep 15, 2023
@nielsenko nielsenko changed the base branch from main to kn/asymmetric-sync September 15, 2023 17:38
@nielsenko nielsenko force-pushed the kn/asymmetric-sync branch 3 times, most recently from 550f53e to c214a5b Compare September 18, 2023 07:59
Base automatically changed from kn/asymmetric-sync to main September 18, 2023 08:49
@nielsenko
Copy link
Contributor Author

nielsenko commented Nov 1, 2023

This requires realm-core v13.21.0 or later (for realm/realm-core#6981)

@nirinchev nirinchev force-pushed the kn/asymmetric-object-allow-non-embedded-links branch from d736e7c to 3b5f999 Compare November 1, 2023 11:16
@nielsenko
Copy link
Contributor Author

@nirinchev I noticed that current CHANGELOG on main says realm-core 13.20.1, but it is really v13.23.2-4-g56a048d9f (ie. v13.23.2 + the XCode 15 fix)

@nielsenko nielsenko marked this pull request as ready for review November 1, 2023 11:32
@nielsenko nielsenko removed their assignment Nov 1, 2023
@nirinchev
Copy link
Member

Yes, I saw that as well, but figured I'll update to the latest stable Core on Friday and just fix it then.

@nirinchev nirinchev self-assigned this Nov 1, 2023
@nirinchev nirinchev merged commit 27742d2 into main Nov 1, 2023
16 checks passed
@nirinchev nirinchev deleted the kn/asymmetric-object-allow-non-embedded-links branch November 1, 2023 13:19
nirinchev added a commit that referenced this pull request Nov 30, 2023
* main:
  Don't add the ISRG X1 Root on Android (#1434)
  Wait for initial sync to complete before starting the tests (#1435)
  kn/update analyzer (#1365)
  Add vNext Changelog header (#1429)
  [Release 1.6.0] (#1428)
  Upgrade to Core 13.23.4 (#1427)
  Flexible sync subscribe/unsubscribe API (#1354)
  Use default context rather than creating a new one (#1426)
  Handle duplicate certificates (#1425)
  kn/add certificate (#1378)
  asymmetric object allow non embedded links (#1402)
  Rudimentary geospatial support (#1389)
  Core 13.20.1 sync errors changes (#1387)
  Fix RealmObject.hashCode (#1420)
  add 'ignore_for_file: type=lint' to *.g.dart files (#1413)
  kn/fix skip then iterate bug (#1410)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow non-embedded links in asymmetric objects
2 participants