Lift link restriction on asymmetric objects

realm · Nov 1, 2023 · 3b5f999 · 3b5f999
1 parent 538c6aa
commit 3b5f999
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 35 deletions.
diff --git a/generator/lib/src/class_element_ex.dart b/generator/lib/src/class_element_ex.dart
@@ -188,17 +188,11 @@ extension ClassElementEx on ClassElement {
         }
       }
 
-      // Check that asymmetric objects:
-      // 1) only have links to embedded objects.
-      // 2) have a primary key named _id.
+      // Check that asymmetric objects have a primary key named _id.
       if (objectType == ObjectType.asymmetricObject) {
         var hasPrimaryKey = false;
         for (final field in mappedFields) {
           final fieldElement = field.fieldElement;
-          final classElement = fieldElement.type.basicType.element as ClassElement;
-          if (field.type.basicType.isRealmModel && !classElement.thisType.isRealmModelOfType(ObjectType.embeddedObject)) {
-            throw RealmInvalidGenerationSourceError('Asymmetric objects cannot link to non-embedded objects', todo: '', element: fieldElement);
-          }
           if (field.isPrimaryKey) {
             hasPrimaryKey = true;
             if (field.realmName != '_id') {

diff --git a/generator/test/error_test_data/asymmetric_link_to_non_embedded.dart b/generator/test/error_test_data/asymmetric_link_to_non_embedded.dart
diff --git a/generator/test/error_test_data/asymmetric_link_to_non_embedded.expected b/generator/test/error_test_data/asymmetric_link_to_non_embedded.expected
diff --git a/test/asymmetric_test.dart b/test/asymmetric_test.dart
@@ -59,17 +59,16 @@ Future<void> main([List<String>? args]) async {
     await realm.syncSession.waitForUpload();
   });
 
-  baasTest('Asymmetric tricks to add non-embedded links', (config) async {
-    final realm = await getIntegrationRealm(appConfig: config);
+  baasTest('Asymmetric add non-embedded links', (config) async {
+    final realm = await getSyncRealm(config);
 
     realm.subscriptions.update((mutableSubscriptions) {
       mutableSubscriptions.add(realm.all<Symmetric>());
     });
 
     realm.write(() {
       final s = realm.add(Symmetric(ObjectId()));
-      // Since this shenanigan is allowed, I have opened a feature request to allow
-      // direct links on a symmetric objects. See https://github.com/realm/realm-core/issues/6976.
+      realm.ingest(Asymmetric(ObjectId(), symmetric: s));
       realm.ingest(Asymmetric(ObjectId(), embeddedObjects: [Embedded(1, symmetric: s)]));
       realm.ingest(Asymmetric(ObjectId(), embeddedObjects: [Embedded(1, any: RealmValue.from(s))]));
     });

diff --git a/test/test.dart b/test/test.dart
@@ -333,6 +333,7 @@ class _Asymmetric {
   @MapTo('_id')
   late ObjectId id;
 
+  _Symmetric? symmetric;
   late List<_Embedded> embeddedObjects;
 }