-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation: remove code for config file v1 and default config file #10367
Conversation
This is a continuation of the work done for * #10351 * #10342 * #10348 * #10355 In that work we added notifications, warning messages and finally a feature flag to start failing the builds without a configuration file or using v1. This commit removes all the code for config file v1 and building without a configuration file. Due to that, it also removes the code that allows users to use the older Docker images (testing, latest, stable) This work can be merged once we enable the feature flag to fail the builds for all the projects and we are happy with the results.
I created a Metabase question to know how many projects are still manually specifying |
- python.version - python.system_packages People should not be using these keys.
Update this PR to |
…mitos/deprecation-no-config-file-and-v1
I updated this PR with the latest changes from
We are deprecating this on October 16th (see #10587), so we may want to merge this after that day or adapt this PR to keep |
@humitos I saw merging this in the release tasks, but seems it's not ready? |
He, yeah. I added this PR into this release a long time ago expecting to be ready by this time 😅 I'll update it in the next few days and ask for a review. |
Due to #10367 (comment), I think we can merge this PR after October 16th and reduce the workload in our side. |
This PR is ready to review and merge. After that, we can also merge https://github.com/readthedocs/readthedocs-ops/pull/1383 to remove old Docker images from AMI and builders. |
…mitos/deprecation-no-config-file-and-v1
@stsewd @ericholscher this PR removes everything related to config file v1 and default config file. I'd appreciate a review on it so we can move forward with this deprecation and finally remove this code from our repository. Note that there is no need to do an extensive review on it since it's pretty big and, in theory, there is no changes in logic or similar. All the code removed from this PR should not be used by anybody at this point since we already passed the final removal date. Also, since it changes 5k lines, I'd appreciate if we can merge it sooner and make the needed/small changes in another PR if required to avoid having to deal with merge conflicts again. |
This is a continuation of the work done for
In that work we added notifications, warning messages and finally a feature flag to start failing the builds without a configuration file or using v1.
This commit removes all the code for config file v1 and building without a configuration file. Due to that, it also removes the code that allows users to use the older Docker images (testing, latest, stable)
This work can be merged once we enable the feature flag to fail the builds for all the projects and we are happy with the results.
Related:
build.image
config #10589