Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make current config version more prominent in our docs #8648

Closed
2 tasks
agjohnson opened this issue Nov 3, 2021 · 6 comments · Fixed by #10416
Closed
2 tasks

Make current config version more prominent in our docs #8648

agjohnson opened this issue Nov 3, 2021 · 6 comments · Fixed by #10416
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: documentation Documentation is required

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Nov 3, 2021

I was browsing our docs and noticed this page (clicking on "Configuration File" in the TOC):
https://docs.readthedocs.io/en/stable/config-file/index.html

It feels we could guide the user better by replacing this index page with the content from:
https://docs.readthedocs.io/en/stable/config-file/v2.html

The config index page:

  • Mentions the file name you should use
  • Mentions file names you shouldn't use. This probably should be in advanced usage, or at least somewhere not the first thing users would interact with
  • Mentions why you should use a configuration file over our interface. Our stance could be firmer and clearer here. Use the configuration file, full stop.
  • Lists version 2 and version 1 configuration file structure. Which one am I supposed to use as a user?

The V2 config file (and I'll touch on the naming convention thing) accomplish:

  • Mentions the config file name
  • Shows a great example of a documentation file
  • Though it's hard to navigate and digest, this file at least describes all of the options right in the same document. All of our options are easy to find.

So, it could make sense to do the following:

  • Replace the index.rst with v2.rst docs. That is, when the user clicks on "Configuration File", we give them "Here is our configuration file, and here is how you use it". Don't be impartial about which version to use, or how users interact with project settings, and be clearer about how many versions the user needs to be aware of (1).
  • Don't reference this as config file V2, instead it's just our config file. There is an old version you can use but it's not supported. This is to be clear about what version of our config file to use.

Separately, there are some issues with the display of the config file that make it hard for me to find information. I suppose it's rather dense documentation. More frequent examples, or perhaps a custom formatting to config file options would make this easier to scan for information.

@agjohnson agjohnson added the Improvement Minor improvement to code label Nov 3, 2021
@humitos humitos added the Needed: documentation Documentation is required label Nov 3, 2021
@astrojuanlu
Copy link
Contributor

I wholeheartedly agree with this, I have thought about it many times. In particular:

Don't be impartial about which version to use

I'll raise the bar even more: why keep v1 around?

@astrojuanlu astrojuanlu changed the title Tune our configuration file docs Make current config version more prominent in our docs Nov 3, 2021
@agjohnson
Copy link
Contributor Author

That could absolutely be an option, though perhaps it's a bit longer time frame. We could pull usage information on this rather easily as well though, perhaps it's not used much (it probably is).

This might be a good place to lead ahead of feature deprecation though. Soft deprecation might be to stop pointing users to the v1 docs, or at least making them first page prominent. Medium deprecation is maybe notifications through various projects we've discussed recently about notifying users on deprecated features more, and hard deprecation is a build warning/error.

@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Mar 2, 2022
@humitos humitos added the Accepted Accepted issue on our roadmap label Mar 2, 2022
@stale stale bot removed the Status: stale Issue will be considered inactive soon label Mar 2, 2022
@agjohnson agjohnson moved this to Planned in 📍Roadmap Sep 7, 2022
@benjaoming
Copy link
Contributor

Let's make sure that #9921 fixes this. I haven't gone over this issue in relation with the PR, but I think it's likely that it will solve it.

@humitos
Copy link
Member

humitos commented May 31, 2023

We are deprecating config file v1. I opened an initial work in progress at #10367. Hopefully, once that's merged we won't be mentioning other version than v2.

@benjaoming
Copy link
Contributor

We did some changes in #10416. They address most concerns in this issue, so I think we should close it 👍

It'll get even better when #10367 deletes the perhaps rather confusing v1 reference and really clarifies everywhere that a configuration file is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
Archived in project
5 participants