Skip to content

refactor: smol type improvement for reference pages #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

kanadgupta
Copy link
Member

🧰 Changes

just a small type addition to reflect the new support for reference pages. we'll want to make a similar change for custom pages + changelog too.

@kanadgupta kanadgupta added enhancement New feature or request refactor Issues about tackling technical debt labels Jun 23, 2025
@kanadgupta kanadgupta marked this pull request as ready for review June 23, 2025 20:57
@kanadgupta kanadgupta requested review from erunion and emilyskuo June 23, 2025 20:57
@kanadgupta
Copy link
Member Author

ignore the CI failure, working on a fix for that as we speak!

@kanadgupta kanadgupta merged commit dc414d3 into next Jun 23, 2025
19 of 23 checks passed
@kanadgupta kanadgupta deleted the kanad-2025-06-23/page-type-enhancement branch June 23, 2025 21:00
kanadgupta added a commit that referenced this pull request Jun 23, 2025
## 🧰 Changes

we've rolled out background jobs for processing API definition uploads,
but `rdme` failed to account for `pending_update` as a possible API
upload status. this fixes that, and enhances our general type safety a
bit while we're here.

## 🧬 QA & Testing

our CI was previously failing in
#1268 due to this issue — is it
passing now?
@kanadgupta
Copy link
Member Author

🎉 This PR is included in version 10.3.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kanadgupta
Copy link
Member Author

🎉 This PR is included in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Issues about tackling technical debt released on @next released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants