Skip to content

fix(openapi/upload): handle pending_update #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Jun 23, 2025

🧰 Changes

we've rolled out background jobs for processing API definition uploads, but rdme failed to account for pending_update as a possible API upload status. this fixes that, and enhances our general type safety a bit while we're here.

🧬 QA & Testing

our CI was previously failing in #1268 due to this issue — is it passing now?

fixes CX-2062

@kanadgupta kanadgupta requested review from erunion and emilyskuo June 23, 2025 21:35
@kanadgupta kanadgupta added refactor Issues about tackling technical debt command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands bug Something isn't working labels Jun 23, 2025
@kanadgupta kanadgupta marked this pull request as ready for review June 23, 2025 21:35
@kanadgupta kanadgupta merged commit 9e94ac1 into next Jun 23, 2025
9 checks passed
@kanadgupta kanadgupta deleted the kanad-2025-06-23/openapi-upload-fix branch June 23, 2025 21:37
kanadgupta pushed a commit that referenced this pull request Jun 23, 2025
# [10.3.0-next.5](v10.3.0-next.4...v10.3.0-next.5) (2025-06-23)

### Bug Fixes

* **openapi/upload:** handle `pending_update` ([#1269](#1269)) ([9e94ac1](9e94ac1))

[skip ci]
@kanadgupta
Copy link
Member Author

🎉 This PR is included in version 10.3.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

kanadgupta pushed a commit that referenced this pull request Jun 24, 2025
# [10.3.0](v10.2.2...v10.3.0) (2025-06-24)

### Bug Fixes

* **lib/fetchSchema:** don't fetch OAS schemas from our API ([#1267](#1267)) ([7344309](7344309))
* **openapi/upload:** handle `pending_update` ([#1269](#1269)) ([9e94ac1](9e94ac1))

### Features

* filter `oas/analyzer` data by allowed keys ([#1259](#1259)) ([766fb42](766fb42))
* new `reference upload` command ([#1261](#1261)) ([01e8198](01e8198))
* properly display file size feature in openapi inspect command ([#1257](#1257)) ([d957cb2](d957cb2))

[skip ci]
@kanadgupta
Copy link
Member Author

🎉 This PR is included in version 10.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working command:openapi Issues pertaining to the `openapi`, `validate`, `reduce`, or `swagger` commands refactor Issues about tackling technical debt released on @next released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants