Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Replace flake8 and isort with ruff #48508

Open
Tracked by #47991
MortalHappiness opened this issue Nov 2, 2024 · 2 comments · May be fixed by #49435
Open
Tracked by #47991

[CI] Replace flake8 and isort with ruff #48508

MortalHappiness opened this issue Nov 2, 2024 · 2 comments · May be fixed by #49435
Assignees
@MortalHappiness
Labels
ci-test

Comments

@MortalHappiness
Copy link
Member

MortalHappiness commented Nov 2, 2024 •
edited
Loading

In #47991 (comment)

Since ruff is drop-in replacement for flake8 so upgrading flake8 and switching to ruff should require the similar amount of efforts.
@MortalHappiness MortalHappiness mentioned this issue Nov 2, 2024
Open
25 tasks
@MortalHappiness MortalHappiness self-assigned this Nov 2, 2024
@MortalHappiness MortalHappiness changed the title Replace flake8, isort, black with ruff [CI] Replace flake8, isort, black with ruff Nov 2, 2024
@MortalHappiness MortalHappiness mentioned this issue Nov 12, 2024
Open
@win5923
Copy link
Contributor

win5923 commented Nov 21, 2024 •
edited
Loading

Hi @MortalHappiness, can you provide some guidance on how to replace flake8, isort, and black with ruff? Apart from updating the .pre-commit-config.yaml to use ruff, what else needs to be done?

@win5923 win5923 mentioned this issue Nov 21, 2024
Closed
8 tasks
@MortalHappiness
Copy link
Member Author

Hi @win5923 Actually, I don't know either. You can check the codebase to see what needs to be changed, and if you have any questions, feel free to ping me, and I can ask others for you.

cc @aslonnie

@MortalHappiness MortalHappiness changed the title [CI] Replace flake8, isort, black with ruff [CI] Replace flake8 and isort with ruff Dec 25, 2024
@MortalHappiness MortalHappiness mentioned this issue Dec 25, 2024
Closed
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
[CI][Linter] Migrate to ruff
795f13c 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Fix SyntaxError files
2f6800c 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Fix files autofixable by ruff
2469fd2 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Run ruff pre-commit rule in CI
0eaaadb 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness MortalHappiness linked a pull request Dec 25, 2024 that will close this issue
Open
8 tasks
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
[CI][Linter] Migrate to ruff
4f7e608 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Fix SyntaxError files
44a6990 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Fix files autofixable by ruff
c6b6f97 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Run ruff pre-commit rule in CI
18e5b64 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
[CI][Linter] Migrate to ruff
0142c72 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Fix SyntaxError files
1569239 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Run ruff pre-commit rule in CI
3c15dc7 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Update noqa comments to use ruff
0438f43 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Update requirements_compiled.txt
18ead33 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Ignore autofixable rules
3474ec9 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Run ruff pre-commit rule in CI
cb3c3d2 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Update noqa comments to use ruff
9e3c87e 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Update requirements_compiled.txt
0e68ed7 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Ignore autofixable rules
aab7d03 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
[CI][Linter] Migrate to ruff
78ab98b 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Fix SyntaxError files
d59f155 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Run ruff pre-commit rule in CI
1debfae 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Update noqa comments to use ruff
e2c608c 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Update requirements_compiled.txt
c43f570 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness added a commit to MortalHappiness/ray that referenced this issue Dec 25, 2024
@MortalHappiness
Ignore autofixable rules
2e84c6a 
Closes: ray-project#48508
Signed-off-by: Chi-Sheng Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortalHappiness MortalHappiness

Labels
ci-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI][Linter] Replace flake8 and isort with ruff MortalHappiness/ray
2 participants
@MortalHappiness @win5923