[CI][Linter] Replace flake8 and isort with ruff
#49435
Open
+176
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
force-pushed
the
feature/#48508-migrate-to-ruff
branch
2 times, most recently
from
18e5b64 to
18ead33
Compare
MortalHappiness
changed the title
flake8 and isort with ruff
MortalHappiness
force-pushed
the
feature/#48508-migrate-to-ruff
branch
from
3474ec9 to
aab7d03
Compare
MortalHappiness
requested review from
edoakes,
zcin,
GeneDer,
akshay-anyscale,
a team,
hongpeng-guo,
justinvyu,
matthewdeng,
raulchen,
woshiyyya,
sven1977,
maxpumperla and
simonsays1980
as code owners
MortalHappiness
assigned MortalHappiness, aslonnie, dayshah and jjyao and unassigned MortalHappiness
MortalHappiness
added a commit
to MortalHappiness/ray
that referenced
this pull request
Dec 25, 2024
Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#48508 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#48508 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#48508 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#48508 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#48508 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#48508 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#48508-migrate-to-ruff
branch
from
aab7d03 to
2e84c6a
Compare
MortalHappiness
commented
Dec 26, 2024
| hooks: | ||
| - id: ruff | ||
| args: [ --fix, --exit-non-zero-on-fix ] | ||
| # - id: ruff-format |
There was a problem hiding this comment.
This will be uncommented in the follow-up PR to replace the black formatter.
| # TODO(barakmich): This should be cleaned up. I've at least excised the copies | ||
| # of these arguments to this location, but the long-term answer is to actually | ||
| # make a flake8 config file | ||
| FLAKE8_PYX_IGNORES="--ignore=C408,E121,E123,E126,E211,E225,E226,E227,E24,E704,E999,W503,W504,W605" |
There was a problem hiding this comment.
Currently, ruff does not support Cython.
In fact, flake8 also does not directly support Cython, which is why many rules need to be ignored here. If Cython support is still needed, this can be addressed in a follow-up PR by running ruff on Cython files, while similarly ignoring many rules.
Comment on lines
344
to
+345
| " image = self.pipe(prompt, num_inference_steps=50, guidance_scale=7.5).images[0]\n", | ||
| "\t\treturn image\n", | ||
| " return image\n", |
There was a problem hiding this comment.
This fixes IndentationError.
|
cool! @aslonnie any comments? |
|
Lonnie is OOO for a few weeks. @can-anyscale any opposition to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR replaces
flake8andisortwithruff.To minimize changes, all rules that cause file modifications are ignored.
Although this PR involves many files, the changes to Python files are limited to modifications of flake8 comments.
The latest version of
ruffdoes not support disabling checks forSyntaxError, sopython/ray/serve/tests/test_config_files/syntax_error.pyis explicitly excluded inpyproject.toml. See https://docs.astral.sh/ruff/rules/syntax-error/ for details.Follow-up:
blackwithruff format#49436Related issue number
Closes #48508
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.