Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove noqa comments after flake8 being upgraded to 7.1.1 #48147

Closed
MortalHappiness opened this issue Oct 22, 2024 · 1 comment
Closed

Remove noqa comments after flake8 being upgraded to 7.1.1 #48147

MortalHappiness opened this issue Oct 22, 2024 · 1 comment
Assignees
@MortalHappiness
Labels
ci-test

Comments

@MortalHappiness
Copy link
Member

MortalHappiness commented Oct 22, 2024 •
edited
Loading

This is a subtask of #47991. See the parent issue for more information.

For some rules, the behavior of old and new version of flake8 are different. So some TODO comments are added while fixing those rules. We need to remove those TODO comments and noqa comments after flake8 being upgraded to 7.1.1.

PRs that added TODO comments:
@MortalHappiness MortalHappiness mentioned this issue Oct 22, 2024
Open
26 tasks
@MortalHappiness MortalHappiness self-assigned this Oct 22, 2024
@MortalHappiness
Copy link
Member Author

Close this PR because #48508 will handle noqa comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MortalHappiness MortalHappiness

Labels
ci-test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MortalHappiness