Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: migrates core resources to v2 APIs #340

Merged
merged 54 commits into from
Sep 4, 2024
Merged
Changes from 1 commit
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
642dfeb
feat(disks): use v2 APIs for Disk operations
ankitrgadiya Mar 21, 2024
3a6a7d0
feat(networks): uses v2 networks APIs
RomilShah Mar 21, 2024
b16edb0
feat(packages): uses v2 packages APIs
RomilShah Feb 23, 2024
b78f41d
feat(deployment): uses v2 deployments APIs
RomilShah Apr 23, 2024
58cd08b
fix(deployments): implements waiting mechanism for disk and network d…
RomilShah Jul 8, 2024
0cacf38
fix(package): allow executable command to be string, array or null
ankitrgadiya Jul 11, 2024
04f03d6
fix(deployments): fix deployment status and wait command
smrutisenapati Jul 16, 2024
8b84b46
fix(networks): fix device network schema
smrutisenapati Jul 16, 2024
6a7ae65
fix(networks): fix network type flag
smrutisenapati Jul 16, 2024
bab4898
fix(deployments): fix deployment wait command
smrutisenapati Jul 17, 2024
3e6d7b7
fix(deployments): adds stopped at time for deployment list
smrutisenapati Jul 17, 2024
9101b01
fix(manifests): fix manifests of resources
smrutisenapati Jul 17, 2024
339c5d1
fix(v2client): fix v2 client org header
smrutisenapati Jul 17, 2024
34ac1c9
fix(networks): delete in use network
smrutisenapati Jul 17, 2024
606c940
fix(packages): fix package commands
smrutisenapati Jul 21, 2024
506426a
fix(network): fix network commands
smrutisenapati Jul 21, 2024
6672b74
fix(disk): fix disk commands
smrutisenapati Jul 21, 2024
53c1ce3
fix(deployment): fix deployment commands
smrutisenapati Jul 21, 2024
1fd0546
feat(v2client): adds poll methods and stream deployment logs method
smrutisenapati Jul 21, 2024
f35c2db
fix: fixes resolver and resource models to work with apply
smrutisenapati Jul 21, 2024
966dbf2
fix(v2client): fix retry exceeded error code description and action
smrutisenapati Jul 22, 2024
dbab2da
fix(jsonschema): remove interface from deployment rosNetworks
pallabpain Jul 24, 2024
b14a72d
refactor(v2client): update list* functions to use _walk_pages helper
ankitrgadiya Jun 27, 2024
b71eae3
fix(rosbag): update default statuses for list functions
ankitrgadiya Jun 27, 2024
f3852b0
fix(deployment): add phase filter for list_deployments
ankitrgadiya Jun 27, 2024
9d65742
feat(config): store org short id in the cli config
pallabpain Jul 30, 2024
bae925d
refactor(apply): removes resolver cache
pallabpain Jul 29, 2024
f99518b
refactor(explain): updates example manifests
pallabpain Jul 31, 2024
49b328b
refactor: removes examples directory
pallabpain Aug 2, 2024
4c5c040
fix(template): validate manifests against jsonschema
pallabpain Jul 31, 2024
50b7f22
chore: bumps rapyuta_io version to 1.17.0
pallabpain Aug 1, 2024
e14ae5c
perf(delete): implements multi-threaded delete operation
pallabpain Aug 1, 2024
3c73977
fix(deployment): replace aggregateStatus with status
pallabpain Aug 2, 2024
018e118
feat(apply): init Jinja environment with filters and rio namespace
pallabpain Aug 2, 2024
e092f2f
refactor(deployment): updates deployment list output
pallabpain Aug 2, 2024
cb9e2fe
feat: adds filter by label option in list commands
pallabpain Aug 4, 2024
c00b6f4
fix(jsonschema): corrects resource GUID regex
pallabpain Aug 5, 2024
286db3d
fix(project): fixes raised exception in find_organization_guid helper
pallabpain Aug 6, 2024
96fbb71
fix(jsonschema): accepts null value in deployment features
pallabpain Aug 7, 2024
ca4b688
feat(deployment): implement restart alias for rio deployment update
pallabpain Aug 8, 2024
971e76f
feat(context): add command to view cli config
pallabpain Aug 12, 2024
9fa4435
fix(device): updates client in list device deployments command
pallabpain Aug 19, 2024
985e984
feat(deployment): execute commands on device deployments (#345)
RomilShah Aug 19, 2024
369a070
fix(v2client): corrects status check in poll_disk
pallabpain Aug 21, 2024
860d56d
fix(deployment): set replica=0 as default in deployment logs command
pallabpain Aug 21, 2024
f548d8c
feat(deployment): wait until all dependecies are running
pallabpain Aug 21, 2024
5fac718
fix(disk): prints a better message when no disks are deleted
pallabpain Aug 21, 2024
65e3b7e
refactor(apply): prints specific status messages
pallabpain Aug 22, 2024
9038bd8
ci: updates workflow names
pallabpain Aug 22, 2024
6098fff
fix(configtree): returns error when no files are provided in import
pallabpain Aug 23, 2024
55cb7b4
fix(apply): prints resource name when apply or delete fails
pallabpain Aug 26, 2024
acdbd87
fix(delete): prints appropriate message when deletionPolicy = retain
pallabpain Sep 2, 2024
4ca439a
ci: deletes old comments when new appimage is uploaded
guptadev21 Sep 2, 2024
e6f5927
feat(v2client): inject X-Request-ID in headers if REQUEST_ID in env
YaswanthKumar-eng Sep 4, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci: deletes old comments when new appimage is uploaded
This commit updates the AppImage workflow to delete older comments
that publish the link to the artifacts before adding the new comment
ensuring that there's always one latest comment with the link to the
last successful AppImage build on a PR.

Wrike Ticket: https://www.wrike.com/open.htm?id=1130198233
guptadev21 authored and pallabpain committed Sep 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 4ca439af979ab075840118f2d9ef0652c65362ab
38 changes: 37 additions & 1 deletion .github/workflows/upload-appimage.yml
Original file line number Diff line number Diff line change
@@ -34,8 +34,44 @@ jobs:
if-no-files-found: error
retention-days: 15

- name: Artifact Comment on PR
- name: Install GitHub CLI
run: |
sudo apt-get update
sudo apt-get install gh

- name: Edit the last bot comment
id: edit-comment
if: github.event_name == 'pull_request'
run: |
set -e
gh pr comment $PR_NUMBER --edit-last -b "
**🤖 Pull Request [Artifacts](https://github.com/rapyuta-robotics/rapyuta-io-cli/actions/runs/"$RUN_ID") (#"$RUN_ID") 🎉**
"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
RUN_ID: ${{ github.run_id }}
PR_NUMBER: ${{ github.event.number }}
continue-on-error: true


- name: Delete existing bot comments
if: steps.edit-comment.outcome == 'failure'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
PR_NUMBER: ${{ github.event.number }}
run: |
# Get all comments on the PR where the author is the bot
COMMENTS=$(gh api repos/${{ github.repository }}/issues/$PR_NUMBER/comments --jq '.[] | select(.user.login == "github-actions[bot]") | .id')

# Loop through each bot comment and delete it
for COMMENT_ID in $COMMENTS; do
gh api repos/${{ github.repository }}/issues/comments/$COMMENT_ID -X DELETE
done


- name: Artifact Comment on PR
# if: github.event_name == 'pull_request'
if: steps.edit-comment.outcome == 'failure'
run: |
gh pr comment $PR_NUMBER -b "
**🤖 Pull Request [Artifacts](https://github.com/rapyuta-robotics/rapyuta-io-cli/actions/runs/"$RUN_ID") (#"$RUN_ID") 🎉**