✨ feat: migrates core resources to v2 APIs #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabpain
force-pushed
the
feat/v2-core-migration
branch
6 times, most recently
from
2c85639 to
c97a174
Compare
pallabpain
added
🐛 bug
pallabpain
commented
Jul 31, 2024
pallabpain
requested review from
amitsingh21 and
rrkumarshikhar
and removed request for
RomilShah
pallabpain
changed the title
pallabpain
force-pushed
the
feat/v2-core-migration
branch
7 times, most recently
from
1a8c9c4 to
a1d347d
Compare
When features is null, the jsonschema validation fails for deployment manifests. This commit fixes the issue by extending the valid types for features. Wrike Ticket: https://www.wrike.com/open.htm?id=1466707323
The rio deployment update command essentially restarts the deployment and serves no other purpose. Hence, it makes sense to rename the command to restart. However, there may be scripts that are currently using the update command and hence, in order to maintain compatibility, we implement an alias in this commit and mark the update command as deprecated. Wrike Ticket: https://www.wrike.com/open.htm?id=1470267514
This commit introduces a sub-command to manage the CLI context.
The rio device deployment command was still using the old client to invoke the list deployments API. This commit updates the command to use the v2 client with the right query parameters.
This commit updates the rio deployment execute command to run commands on device deployments. BREAKING CHANGE: The rio deployment execute command no longer supports cloud deployments.
The poll_disk method has 'Bound' in the list of statuses which caused the apply command to fail when a deployment depends on a disk. The poll_disk is supposed to wait until the status changes to 'Available' before returning. This commit fixes the issue.
The replica value defaults to None in the existing implementation which results in a wrong value sent in the query parameter. This commit fixes the issue by setting the default to 0. Wrike Ticket: https://www.wrike.com/open.htm?id=1478463257
pallabpain
force-pushed
the
feat/v2-core-migration
branch
2 times, most recently
from
35951d0 to
7987a54
Compare
This commit adds a field in the deployment schema to wait for dependencies to come to a running state before a deployment is created.
When no disks are deleted using the rio disk delete command, the existing implementation returns a message that's not really accurate. Ideally, it should say that no disk was deleted. This commit fixes the issue. Wrike Ticket: https://www.wrike.com/open.htm?id=1478463819
pallabpain
force-pushed
the
feat/v2-core-migration
branch
from
7987a54 to
9038bd8
Compare
The files argument in the import command is variadic. If you forget specifying a tree name and pass only file to import, it will assume the file as the tree name and the files tuple will be empty. It has to be handled explicitly per the documentation here: https://click.palletsprojects.com/en/8.1.x/arguments/
When the apply or delete command fails, it doesn't clearly mention which resource failed. This commit fixes the issue by printing the resource name along with the eror. Wrike Ticket: https://www.wrike.com/open.htm?id=1480954550
When deletion policy for a resource is set to `retain` in the manifest, the delete command should print an appropriate error message.
|
🤖 Pull Request Artifacts (#10699045624) 🎉 |
This commit updates the AppImage workflow to delete older comments that publish the link to the artifacts before adding the new comment ensuring that there's always one latest comment with the link to the last successful AppImage build on a PR. Wrike Ticket: https://www.wrike.com/open.htm?id=1130198233
pallabpain
force-pushed
the
feat/v2-core-migration
branch
from
4d94770 to
f645f73
Compare
If REQUEST_ID is set in the system env, then all v2 API calls will have X-Request-ID header set to the value of REQUEST_ID. This is particularly helpful in debugging.
pallabpain
force-pushed
the
feat/v2-core-migration
branch
from
f645f73 to
e6f5927
Compare
ankitrgadiya
approved these changes
Sep 4, 2024
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request contains more than just migrating resources to v2. It also refactors the core applier in the CLI and removes the resolver cache that has been adding significant overheads while processing and applying manifests.
Demos
Performance improve in the
applyanddeletecommandsDepends