Retry error logging #1844
Merged
Retry error logging #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eption messages" (rapidsai#1843)" This reverts commit 01edf5a.
bdice
requested changes
Feb 28, 2025
There was a problem hiding this comment.
@pmattione-nvidia Thanks. I took a quick look at the bugfix commit and it seems fine. I would like to wait to merge this until we get cuDF's CI passing again, to avoid extending the current disruption due to nightly failures. I'm requesting changes for the moment.
bdice
approved these changes
Mar 4, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry getting improved error throwing and logging, with bugs fixed and test added that repros the cudf failure. Original PR that was reverted.
The changes to the previously-approved PR that includes the fixes and test is this commit. The original while loop has been restored with better error handling.
Note that this changes the interface of the macros, one of which is called in cudf that will be changed here after this goes in.
Checklist