Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Test internal macros and discourage external usage #1848

Open
bdice opened this issue Mar 4, 2025 · 2 comments · May be fixed by #1847
Open

[FEA] Test internal macros and discourage external usage #1848

bdice opened this issue Mar 4, 2025 · 2 comments · May be fixed by #1847
Assignees
Labels
feature request New feature or request

Comments

@bdice
Copy link
Contributor

bdice commented Mar 4, 2025

RMM pull request #1827 changed the internal macro RMM_CUDA_TRY_ALLOC, which broke cuDF and led to rapidsai/cudf#18108.

Before merging #1844, I made the internal changes to RMM_CUDA_TRY_ALLOC non-breaking, because of that macro's use in cuDF and cuVS: https://github.com/search?q=org%3Arapidsai+RMM_CUDA_TRY_ALLOC+-repo%3Arapidsai%2Frmm&type=code

We need to test our macros, because of their vital importance for internal consistency and error handling.

We also need external libraries (cuDF, cuVS) to stop using the internal macros because they are not public API.

@bdice bdice added the feature request New feature or request label Mar 4, 2025
@bdice bdice self-assigned this Mar 4, 2025
@bdice bdice linked a pull request Mar 4, 2025 that will close this issue
3 tasks
@bdice
Copy link
Contributor Author

bdice commented Mar 4, 2025

@vyasr
Copy link
Contributor

vyasr commented Mar 4, 2025

This has bitten us before and I would support prioritizing getting other libraries off of these macros (and doing the same thing for other repo macros, e.g. removing cuspatial's usage of cudf macros if we haven't already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: To-do
Development

Successfully merging a pull request may close this issue.

2 participants