You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This has bitten us before and I would support prioritizing getting other libraries off of these macros (and doing the same thing for other repo macros, e.g. removing cuspatial's usage of cudf macros if we haven't already.
RMM pull request #1827 changed the internal macro
RMM_CUDA_TRY_ALLOC
, which broke cuDF and led to rapidsai/cudf#18108.Before merging #1844, I made the internal changes to
RMM_CUDA_TRY_ALLOC
non-breaking, because of that macro's use in cuDF and cuVS: https://github.com/search?q=org%3Arapidsai+RMM_CUDA_TRY_ALLOC+-repo%3Arapidsai%2Frmm&type=codeWe need to test our macros, because of their vital importance for internal consistency and error handling.
We also need external libraries (cuDF, cuVS) to stop using the internal macros because they are not public API.
The text was updated successfully, but these errors were encountered: