Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NumPy <2 pin #4615
Remove NumPy <2 pin #4615
Changes from 23 commits
acafdae
df1f21d
7d6267e
287d629
d54b7d8
3384bc6
37d2ca0
21b689b
d898b84
1d66490
ba6cbab
6fa8d19
0e37bda
a7d9a6b
f74daa3
3fea26d
5e88901
2929e81
16b457d
cecafb4
efdff0a
7926695
a49f912
195c5df
7d7d042
d818cf0
1320573
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently bumped the NCCL floor to 2.18.1.1 in PR: #4661
Reading this comment, am wondering whether we need to bump it further (namely to 2.19)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising in the NCCL update issue: rapidsai/build-planning#102 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to bump the floor on these as well?