-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove NumPy <2 pin #4615
Merged
Merged
Remove NumPy <2 pin #4615
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
acafdae
Remove NumPy <2 pin.
seberg df1f21d
Include pre-release identifier for upper pin
seberg 7d6267e
Merge branch 'branch-24.10' into my_new_branch
seberg 287d629
Merge branch 'branch-24.10' into my_new_branch
jakirkham d54b7d8
Try removing torch pin from tests, add torchdata/pydantic explicitly
seberg 3384bc6
Readd PyTorch and relax upperbound
jakirkham 37d2ca0
Merge branch 'branch-24.10' into my_new_branch
jakirkham 21b689b
Updates test to ensure a query string is created using integer vertex…
rlratzel d898b84
Cleanup based on review feedback: uses a list comprehension instead o…
rlratzel 1d66490
Merge branch 'branch-24.10' into my_new_branch
alexbarghi-nv ba6cbab
Merge branch 'branch-24.10' into my_new_branch
jakirkham 6fa8d19
Merge branch 'branch-24.10' into my_new_branch
seberg 0e37bda
Merge branch 'branch-24.10' into my_new_branch
jameslamb a7d9a6b
Merge remote-tracking branch 'upstream/branch-24.10' into my_new_branch
hcho3 f74daa3
Force install Numpy 2.0
hcho3 3fea26d
Merge remote-tracking branch 'upstream/branch-24.10' into numpy20_sup…
hcho3 5e88901
Pin pytorch<2.4
hcho3 2929e81
Add pin pytorch<2.4
hcho3 16b457d
Reviewer's comment
hcho3 cecafb4
Update Conda recipes
hcho3 efdff0a
Merge remote-tracking branch 'upstream/branch-24.10' into numpy20_sup…
hcho3 7926695
Merge branch 'branch-24.10' into my_new_branch
jameslamb a49f912
Use pytorch 2.3.0
hcho3 195c5df
Merge remote-tracking branch 'upstream/branch-24.10' into numpy20_sup…
hcho3 7d7d042
Bump nccl; update torch pins
hcho3 d818cf0
Fix
hcho3 1320573
Merge branch 'branch-24.10' into my_new_branch
jakirkham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ doxygen_version: | |
- ">=1.8.11" | ||
|
||
nccl_version: | ||
- ">=2.18.1.1" | ||
- ">=2.19" | ||
|
||
c_stdlib: | ||
- sysroot | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently bumped the NCCL floor to 2.18.1.1 in PR: #4661
Reading this comment, am wondering whether we need to bump it further (namely to 2.19)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising in the NCCL update issue: rapidsai/build-planning#102 (comment)