Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor reusable workflows to not grab scripts from Shell #12824

Open
aalves08 opened this issue Dec 5, 2024 · 1 comment · May be fixed by #12946
Open

Refactor reusable workflows to not grab scripts from Shell #12824

aalves08 opened this issue Dec 5, 2024 · 1 comment · May be fixed by #12946
Assignees
@aalves08
Labels
area/extensions kind/tech-debt Technical debt QA/None

Comments

@aalves08
Copy link
Member

aalves08 commented Dec 5, 2024 •
edited
Loading

The reusable workflows build-extension-charts and build-extension-catalog make use of a couple of scripts, as per https://github.com/rancher/dashboard/blob/master/.github/workflows/build-extension-charts.yml#L80-L102, that are being pulled from the client's shell package.

The goal here is to update these workflows to that we use the versions of those scripts in each branch (for latest would be master branch) so that we can apply fixes without the need for the client to update shell

Testing should be already covered in https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-master.yml + https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-release-2.9.yml + https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-release-2.8.yml
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Dec 5, 2024
@aalves08 aalves08 added kind/tech-debt Technical debt area/extensions QA/None and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Dec 5, 2024
@aalves08 aalves08 mentioned this issue Dec 5, 2024
Closed
@aalves08 aalves08 self-assigned this Dec 5, 2024
@aalves08
Copy link
Member Author

aalves08 commented Dec 6, 2024

First approach, which is to clone the extension repo won't work if the repo is private.

Will need to discard this solution as we can’t break the publish procedure for devs with private Github repos.

Moving this issue to Ice Box for now

@aalves08 aalves08 linked a pull request Dec 24, 2024 that will close this issue
Draft
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aalves08 aalves08

Labels
area/extensions kind/tech-debt Technical debt QA/None
Projects
None yet
Milestone
No milestone
1 participant
@aalves08