Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: Refactor build-extension-charts workflow in master to use scripts from upstream (dashboard) #12946

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Dec 24, 2024

Summary

Fixes #12824

Occurred changes and/or fixed issues

  • Refactor build-extension-charts workflow in master to use scripts from upstream (dashboard) instead of shell package

Technical notes summary

The reusable workflows build-extension-charts and build-extension-catalog make use of a couple of scripts, as per https://github.com/rancher/dashboard/blob/master/.github/workflows/build-extension-charts.yml#L80-L102, that are being pulled from the client's shell package.

The goal here is to update these workflows to that we use the versions of those scripts in each branch (for latest would be master branch) so that we can apply fixes without the need for the client to update shell

Testing should be already covered in https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-master.yml + https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-release-2.9.yml + https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-release-2.8.yml

This is a working proposal, tested on Elemental repo

Workflow that ran: https://github.com/rancher/elemental-ui/blob/0cfbc152983d6f8631cac1c022a6f216570e7796/.github/workflows/build-extension-charts.yml

pipeline success: https://github.com/rancher/elemental-ui/actions/runs/12483392216/job/34839112211

Extension installed:
Screenshot 2024-12-24 at 15 27 01
Screenshot 2024-12-24 at 15 27 05

The goal is, if there are no impediments by analysing this PR, to apply these changes to the release-2.8 and release-2.9 branches, so that we can, afterwards, attack with full force some small issues that we've identified with the scripts.

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor reusable workflows to not grab scripts from Shell
1 participant