proposal: Refactor build-extension-charts workflow in master to use scripts from upstream (dashboard) #12946
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12824
Occurred changes and/or fixed issues
build-extension-charts
workflow inmaster
to use scripts from upstream (dashboard) instead of shell packageTechnical notes summary
The reusable workflows
build-extension-charts
andbuild-extension-catalog
make use of a couple of scripts, as per https://github.com/rancher/dashboard/blob/master/.github/workflows/build-extension-charts.yml#L80-L102, that are being pulled from the client'sshell
package.The goal here is to update these workflows to that we use the versions of those scripts in each branch (for
latest
would bemaster
branch) so that we can apply fixes without the need for the client to update shellTesting should be already covered in https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-master.yml + https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-release-2.9.yml + https://github.com/rancher/dashboard/blob/master/.github/workflows/test-extension-workflows-release-2.8.yml
This is a working proposal, tested on Elemental repo
Workflow that ran: https://github.com/rancher/elemental-ui/blob/0cfbc152983d6f8631cac1c022a6f216570e7796/.github/workflows/build-extension-charts.yml
pipeline success: https://github.com/rancher/elemental-ui/actions/runs/12483392216/job/34839112211
Extension installed:
The goal is, if there are no impediments by analysing this PR, to apply these changes to the
release-2.8
andrelease-2.9
branches, so that we can, afterwards, attack with full force some small issues that we've identified with the scripts.Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video
Checklist