Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow build-extension-charts should fail on wrong tagging #12718

Closed
aalves08 opened this issue Nov 29, 2024 · 3 comments
Closed

Workflow build-extension-charts should fail on wrong tagging #12718

aalves08 opened this issue Nov 29, 2024 · 3 comments

Comments

@aalves08
Copy link
Member

aalves08 commented Nov 29, 2024

Workflow build-extension-charts should fail on wrong tagging as per https://github.com/nwmac/rancher-dev-portal/actions/runs/12083482784/job/33696700701.

Look at parse-tag-name script to check why it didn't fail + Run build script job should have also failed. Both should have thrown meaningful errors and exit properly to "kill" workflow run.

UPDATE (9-dec-2024): Solution here is to have parse-tag-name fail if tag check is not met. We can't push responsibility to the publish script as it needs to be able so skip extension tag matching if it's not met and that happens on purpose, since we can have multiple extensions inside the same repo

@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Nov 29, 2024
@aalves08 aalves08 added kind/bug area/extensions QA/None and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Nov 29, 2024
@aalves08 aalves08 self-assigned this Nov 29, 2024
@aalves08
Copy link
Member Author

aalves08 commented Dec 5, 2024

Blocked by #12824

@gaktive
Copy link
Member

gaktive commented Dec 19, 2024

Moved milestone for related PRs to January releases

@aalves08 do we need a 2.10.x version too? I'm not sure how you're tracking everything in one ticket but I trust you to make sure things land in all the releases :)

@aalves08
Copy link
Member Author

😛 we don't need a 2.10 version/fix @gaktive

We only target the branches right before we've had breaking changes on the shell package, which are release-2.8, release-2.9 and master. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants