Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token info bug #1377

Merged
merged 2 commits into from
Feb 24, 2025
Merged

Fix token info bug #1377

merged 2 commits into from
Feb 24, 2025

Conversation

findolor
Copy link
Collaborator

Motivation

See issue: #1369

Solution

  • Add method to parse all token keys for an order
  • Use correct token keys on get all token infos function
  • Update tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

fix #1369

@findolor findolor added bug Something isn't working rust Related to rust crates labels Feb 24, 2025
@findolor findolor requested a review from hardyjosh February 24, 2025 07:36
@findolor findolor self-assigned this Feb 24, 2025
@findolor findolor mentioned this pull request Feb 24, 2025
Merged
4 tasks
@Siddharth2207 Siddharth2207 linked an issue Feb 24, 2025 that may be closed by this pull request
Error when loading custome registry #1375
Closed
@hardyjosh hardyjosh merged commit de960c5 into main Feb 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@findolor findolor

Labels
bug Something isn't working rust Related to rust crates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when loading custome registry getting token info error for sFLR on a base strategy
2 participants
@findolor @hardyjosh