Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State loading issue #1378

Merged
merged 3 commits into from
Feb 24, 2025
Merged

State loading issue #1378

merged 3 commits into from
Feb 24, 2025

Conversation

findolor
Copy link
Collaborator

@findolor findolor commented Feb 24, 2025 •
edited
Loading

Caution

Merge this PR after #1377

Motivation

See issue: #1370

Solution

  • Check token selections on page load
  • Update tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

fix #1370

@findolor findolor added bug Something isn't working webapp labels Feb 24, 2025
@findolor findolor requested a review from hardyjosh February 24, 2025 08:07
@findolor findolor self-assigned this Feb 24, 2025
@hardyjosh hardyjosh merged commit 6b194ac into main Feb 24, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@findolor findolor

Labels
bug Something isn't working webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

on loading from state, even if all tokens are selected the rest of the form is hidden
2 participants
@findolor @hardyjosh