Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move URL update function to gui as a callback #1361

Merged
merged 12 commits into from
Feb 20, 2025
Merged

Move URL update function to gui as a callback #1361

merged 12 commits into from
Feb 20, 2025

Conversation

findolor
Copy link
Collaborator

Motivation

See issue: #1346

Solution

  • Add a callback function to gui that can be passed during chooseDeployment and deserializeState functions.
  • Remove url state update function props from components.
  • Update tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

fix #1346

@findolor findolor added rust Related to rust crates webapp labels Feb 20, 2025
@findolor findolor requested a review from hardyjosh February 20, 2025 06:14
@findolor findolor self-assigned this Feb 20, 2025
@findolor findolor mentioned this pull request Feb 20, 2025
Merged
4 tasks
@findolor findolor merged commit 9edbf36 into main Feb 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh approved these changes

Assignees

@findolor findolor

Labels
rust Related to rust crates webapp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move handleUpdateGuiState function to be called from rust side
2 participants
@findolor @hardyjosh