Update field descriptions on select token change #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardyjosh
reviewed
Feb 19, 2025
|
|
||
| if (allTokensSelected) { | ||
| let newAllTokenInfos = await gui.getAllTokenInfos(); | ||
| if (newAllTokenInfos !== allTokenInfos) { |
There was a problem hiding this comment.
hm this isn't a deep comparison of equality, does it actually work? this is something we should show in a test
also, we are calling getAllTokenInfos with every state change, but we only need to do that if the tokens have changed
so we need more granular control over our state change callback
There was a problem hiding this comment.
I think this will be easier to implement after merging #1361. Let's visit this again after that PR
4 tasks
hardyjosh
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
See issue: #1338
Solution
Checks
By submitting this for review, I'm confirming I've done the following:
fix #1338