Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

02/19/25 remove null gui from deployment steps #1355

Merged
merged 14 commits into from
Feb 21, 2025

Conversation

hardingjam
Copy link
Contributor

@hardingjam hardingjam commented Feb 19, 2025

  • Add a initializeGui function that is called onMount of deployment pages
  • Remove any !gui checks from deployment steps
  • Immediately initialize any values that cannot be changed by the user (subgraphUrl, network key, token selects)

Warning

First, merge #1341, #1342 and #1344

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor marked this pull request as ready for review February 21, 2025 14:06
@hardyjosh hardyjosh enabled auto-merge February 21, 2025 15:54
@hardyjosh hardyjosh merged commit 031d872 into main Feb 21, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants