Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to deleted accounts + emit profile changes #269

Merged
merged 7 commits into from
Nov 19, 2024

wip

185004c
Select commit
Loading
Failed to load commit list.
Merged

Remove references to deleted accounts + emit profile changes #269

wip
185004c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 19, 2024 in 0s

83.9% (-0.1%) compared to da9ecc2

View this Pull Request on Codecov

83.9% (-0.1%) compared to da9ecc2

Details

Codecov Report

Attention: Patch coverage is 73.68421% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.9%. Comparing base (da9ecc2) to head (185004c).

Files with missing lines Patch % Lines
...etworks/network/authorized_dapp/authorized_dapp.rs 0.0% 4 Missing ⚠️
...twork/authorized_dapp/authorized_persona_simple.rs 0.0% 3 Missing ⚠️
.../sargon/src/system/sargon_os/sargon_os_accounts.rs 75.0% 3 Missing ⚠️
...tworks/network/authorized_dapp/shared_with_dapp.rs 0.0% 2 Missing ⚠️
...s/sargon/src/system/sargon_os/sargon_os_profile.rs 83.3% 2 Missing ⚠️
.../profile/v100/networks/network/authorized_dapps.rs 66.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #269     +/-   ##
=======================================
- Coverage   84.0%   83.9%   -0.1%     
=======================================
  Files       1226    1226             
  Lines      21413   21451     +38     
  Branches      77      77             
=======================================
+ Hits       17993   18011     +18     
- Misses      3406    3426     +20     
  Partials      14      14
Files with missing lines Coverage Δ
...ions/identified_vec_of/identified_vec_of_modify.rs 100.0% <ø> (ø)
...c/profile/v100/networks/network/profile_network.rs 100.0% <100.0%> (ø)
...rgon/src/profile/v100/networks/profile_networks.rs 100.0% <100.0%> (ø)
.../profile/v100/networks/network/authorized_dapps.rs 93.3% <66.6%> (-6.7%) ⬇️
...tworks/network/authorized_dapp/shared_with_dapp.rs 96.0% <0.0%> (-4.0%) ⬇️
...s/sargon/src/system/sargon_os/sargon_os_profile.rs 89.8% <83.3%> (+1.3%) ⬆️
...twork/authorized_dapp/authorized_persona_simple.rs 94.3% <0.0%> (-5.7%) ⬇️
.../sargon/src/system/sargon_os/sargon_os_accounts.rs 78.8% <75.0%> (-6.9%) ⬇️
...etworks/network/authorized_dapp/authorized_dapp.rs 94.3% <0.0%> (-5.7%) ⬇️
---- 🚨 Try these New Features:
View more details on Codecov