-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove references to deleted accounts + emit profile changes #269
Conversation
GhenadieVP
commented
Nov 18, 2024
•
edited
Loading
edited
- Emit profile updates when an account is hidden/tombstoned.
- Remove account references from dApps when hidden/tombstoned.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
- Coverage 84.0% 84.0% -0.1%
=======================================
Files 1226 1226
Lines 21413 21451 +38
Branches 77 77
=======================================
+ Hits 17993 18020 +27
- Misses 3406 3417 +11
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
crates/sargon/src/profile/v100/networks/network/authorized_dapp/authorized_persona_simple.rs
Outdated
Show resolved
Hide resolved
crates/sargon/src/profile/v100/networks/network/profile_network.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@GhenadieVP Tested on Android host. Seems good to go. Are we planning on merging it? |