Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to deleted accounts + emit profile changes #269

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

GhenadieVP
Copy link
Contributor

@GhenadieVP GhenadieVP commented Nov 18, 2024

  • Emit profile updates when an account is hidden/tombstoned.
  • Remove account references from dApps when hidden/tombstoned.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 89.47368% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.0%. Comparing base (da9ecc2) to head (185004c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../sargon/src/system/sargon_os/sargon_os_accounts.rs 75.0% 3 Missing ⚠️
...s/sargon/src/system/sargon_os/sargon_os_profile.rs 83.3% 2 Missing ⚠️
...twork/authorized_dapp/authorized_persona_simple.rs 66.6% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #269     +/-   ##
=======================================
- Coverage   84.0%   84.0%   -0.1%     
=======================================
  Files       1226    1226             
  Lines      21413   21451     +38     
  Branches      77      77             
=======================================
+ Hits       17993   18020     +27     
- Misses      3406    3417     +11     
  Partials      14      14             
Flag Coverage Δ
kotlin 98.2% <ø> (ø)
rust 80.2% <89.4%> (-0.1%) ⬇️
swift 97.8% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ions/identified_vec_of/identified_vec_of_modify.rs 100.0% <ø> (ø)
...etworks/network/authorized_dapp/authorized_dapp.rs 100.0% <100.0%> (ø)
...tworks/network/authorized_dapp/shared_with_dapp.rs 100.0% <100.0%> (ø)
.../profile/v100/networks/network/authorized_dapps.rs 100.0% <100.0%> (ø)
...c/profile/v100/networks/network/profile_network.rs 100.0% <100.0%> (ø)
...rgon/src/profile/v100/networks/profile_networks.rs 100.0% <100.0%> (ø)
...twork/authorized_dapp/authorized_persona_simple.rs 98.1% <66.6%> (-1.9%) ⬇️
...s/sargon/src/system/sargon_os/sargon_os_profile.rs 89.8% <83.3%> (+1.3%) ⬆️
.../sargon/src/system/sargon_os/sargon_os_accounts.rs 78.8% <75.0%> (-6.9%) ⬇️
---- 🚨 Try these New Features:

@GhenadieVP GhenadieVP marked this pull request as ready for review November 19, 2024 07:43
Copy link
Contributor

@CyonAlexRDX CyonAlexRDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@micbakos-rdx
Copy link
Contributor

@GhenadieVP Tested on Android host. Seems good to go. Are we planning on merging it?

@GhenadieVP GhenadieVP merged commit b2b2f2a into main Nov 19, 2024
11 of 12 checks passed
@GhenadieVP GhenadieVP deleted the emit_profile_update_through_driver branch November 19, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants