Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use thiserror within crates #111

Merged
merged 51 commits into from
Apr 22, 2024
Merged

chore: use thiserror within crates #111

merged 51 commits into from
Apr 22, 2024

Conversation

brunopgalvao
Copy link
Contributor

AlexD10S and others added 30 commits April 9, 2024 11:16
@AlexD10S
refactor: move everything to crates folder
abf13fa
@AlexD10S
refactor: new and build contracts
778d380
@AlexD10S
refactor: test contract functionality in pop_contracts
b16f4b2
@AlexD10S
refactor: up and call contracts
2a45362
@AlexD10S
refactor: cargo
36c14c8
@AlexD10S
refactor: new parachain and pallet
9dd8965
@AlexD10S
refactor: build parachain
1cd078d
@AlexD10S
refactor: up parachain
faeeec5
@AlexD10S
refactor: clean cargo pop-cli
6a38865
@AlexD10S
docs: pop-contracts README
60d0b51
@AlexD10S
docs: pop-parachains README
9c91278
@AlexD10S
chore: fmt
0f3e95a
@AlexD10S
chore: versions of crates to 0.0.0
710d8ca
@AlexD10S
chore: version 0.1.0 for crates
537c812
@AlexD10S
refactor: shared dependencies in workspace Cargo.toml
9f1fb32
@AlexD10S
refactor: move dependencies to workspace
f061585
@AlexD10S
docs: feedback on docs
9d214e1
@AlexD10S
chore: merge main
5da3761
@AlexD10S
chore: remove version for local dependencies
1842974
@brunopgalvao
use thiserror
a405e7d
@brunopgalvao
use thiserror
00c028a
@brunopgalvao
add thiserror dependency
c8e4c47
@AlexD10S
docs: update nitpicks in README
8fd7502
@weezy20
fixes: typo
c373100
@brunopgalvao
use thiserror
9fceacf
@brunopgalvao
use thiserror
8601484
@brunopgalvao
use thiserror in build
4107e44
@brunopgalvao
use thiserror
d112c9a
@brunopgalvao
use thiserror
2651e78
@brunopgalvao
Merge branch 'alex/refactor-frontend-backend' into bruno/use-thiserror
a62d074
@brunopgalvao brunopgalvao changed the title Use thiserror within crates chore: Use thiserror within crates Apr 18, 2024
@brunopgalvao brunopgalvao changed the title chore: Use thiserror within crates chore: use thiserror within crates Apr 18, 2024
@brunopgalvao brunopgalvao marked this pull request as ready for review April 18, 2024 13:42
@brunopgalvao brunopgalvao requested a review from AlexD10S April 18, 2024 13:42
@AlexD10S
Copy link
Collaborator

Nice work!
I see here the tests passes in the CI but for me locally the test test_new_parachain_command_execute is failing, can you double check is passing for you?

AlexD10S
AlexD10S requested changes Apr 19, 2024
View reviewed changes
crates/pop-contracts/src/test.rs Outdated Show resolved Hide resolved
@brunopgalvao
Copy link
Contributor Author

Nice work! I see here the tests passes in the CI but for me locally the test test_new_parachain_command_execute is failing, can you double check is passing for you?

I just ran cargo test --all-features and all tests pass.

@AlexD10S AlexD10S merged commit b9b6a09 into main Apr 22, 2024
1 check passed
@AlexD10S AlexD10S deleted the bruno/use-thiserror branch April 22, 2024 08:44
@AlexD10S AlexD10S mentioned this pull request Jun 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weezy20 weezy20 weezy20 left review comments

@AlexD10S AlexD10S AlexD10S approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review Project Error Handling
3 participants
@brunopgalvao @AlexD10S @weezy20