Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint %<>% in assignment_linter #2020

Merged
merged 7 commits into from
Jul 28, 2023
Merged

lint %<>% in assignment_linter #2020

merged 7 commits into from
Jul 28, 2023

Conversation

MichaelChirico
Copy link
Collaborator

Part of #2008

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Merging #2020 (2fb3335) into main (fed901a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 2fb3335 differs from pull request most recent head 49394e7. Consider uploading reports for the commit 49394e7 to get more accurate results

@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   98.56%   98.56%           
=======================================
  Files         113      113           
  Lines        5003     5006    +3     
=======================================
+ Hits         4931     4934    +3     
  Misses         72       72           
Files Changed Coverage Δ
R/assignment_linter.R 100.00% <100.00%> (ø)

IndrajeetPatil
IndrajeetPatil previously approved these changes Jul 25, 2023
@IndrajeetPatil IndrajeetPatil self-requested a review July 25, 2023 14:24
IndrajeetPatil
IndrajeetPatil previously approved these changes Jul 25, 2023
@MichaelChirico
Copy link
Collaborator Author

Hmm I think I made a mistake, I want to add more tests since it wasn't caught. If multiple assignments generate lints the message will be garbled in some cases IINM.

@IndrajeetPatil
Copy link
Collaborator

Hmm, there also seems to be some link rot.

R/assignment_linter.R Outdated Show resolved Hide resolved
@MichaelChirico MichaelChirico merged commit 1b459fc into main Jul 28, 2023
21 checks passed
@MichaelChirico MichaelChirico deleted the pipe-assign branch July 28, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants