correct message among several lints

R/assignment_linter.R

@@ -112,7 +112,7 @@ assignment_linter <- function(allow_cascading_assign = TRUE,
     }
 
     operator <- xml2::xml_text(bad_expr)
-    lint_message_fmt <- "Use <-, not %s, for assignment."
+    lint_message_fmt <- rep("Use <-, not %s, for assignment.", length(operator))
     lint_message_fmt[operator %in% c("<<-", "->>")] <-
       "%s can have hard-to-predict behavior; prefer assigning to a specific environment instead (with assign() or <-)."
     lint_message_fmt[operator == "%<>%"] <-

tests/testthat/test-assignment_linter.R

@@ -171,3 +171,16 @@ test_that("%<>% throws a lint", {
   # interaction with allow_trailing
   expect_lint("x %<>%\n  sum()", "Assignment %<>% should not be trailing", assignment_linter(allow_trailing = FALSE))
 })
+
+test_that("multiple lints throw correct messages", {
+  expect_lint(
+    "{ x <<- 1; y ->> 2; z -> 3; x %<>% as.character() }",
+    list(
+      list(message = "<<- can have hard-to-predict behavior"),
+      list(message = "->> can have hard-to-predict behavior"),
+      list(message = "Use <-, not ->"),
+      list(message = "Avoid the assignment pipe %<>%")
+    ),
+    assignment_linter(allow_cascading_assign = FALSE)
+  )
+})