Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ProtonVPN instructions to include recent addition of Wireguard #90

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove reference to ProtonVPN in VPN_PORT_FORWARDING_PROVIDER option …
…documentation (not necessary anymore)
MaVdbussche committed Aug 15, 2024
commit 95ec3128faa6a89124f4f94afcb897237e13016c
2 changes: 1 addition & 1 deletion setup/options/port-forwarding.md
Original file line number Diff line number Diff line change
@@ -7,6 +7,6 @@
| Variable | Default | Choices | Description |
| --- | --- | --- | --- |
| `VPN_PORT_FORWARDING` | `off` | `off` or `on` | Enable custom port forwarding code for supported providers |
| `VPN_PORT_FORWARDING_PROVIDER` | Current provider in use | `private internet access` or `protonvpn` | Choose the custom port forwarding code to use. This is useful when using the custom provider with Wireguard. For PIA, make sure you set `SERVER_NAMES=<server-name>`. |
| `VPN_PORT_FORWARDING_PROVIDER` | Current provider in use | `private internet access` | Choose the custom port forwarding code to use. This is useful when using the custom provider with Wireguard. For PIA, make sure you set `SERVER_NAMES=<server-name>`. |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: add v4 comment to remove protonvpn as an option in the code

| `VPN_PORT_FORWARDING_STATUS_FILE` | `/tmp/gluetun/forwarded_port` | Valid filepath | File path to use for writing the forwarded port obtained. |
| `VPN_PORT_FORWARDING_LISTENING_PORT` | | Valid port number | Port redirection for the VPN server side port forwarded. |

Unchanged files with check annotations Beta

## VPN server port forwarding
- `VPN_PORT_FORWARDING=on`

Check failure on line 68 in setup/providers/protonvpn.md

GitHub Actions / verify

Trailing spaces

setup/providers/protonvpn.md:68:1 MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1] https://github.com/DavidAnson/markdownlint/blob/v0.29.0/doc/md009.md
### OpenVPN only

Check failure on line 69 in setup/providers/protonvpn.md

GitHub Actions / verify

Headings should be surrounded by blank lines

setup/providers/protonvpn.md:69 MD022/blanks-around-headings/blanks-around-headers Headings should be surrounded by blank lines [Expected: 1; Actual: 0; Below] [Context: "### OpenVPN only"] https://github.com/DavidAnson/markdownlint/blob/v0.29.0/doc/md022.md
- Also add `+pmp` to your OpenVPN username (thanks to [@mortimr](https://github.com/qdm12/gluetun/issues/1760#issuecomment-1669518288))

Check failure on line 70 in setup/providers/protonvpn.md

GitHub Actions / verify

Lists should be surrounded by blank lines

setup/providers/protonvpn.md:70 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: "- Also add `+pmp` to your Open..."] https://github.com/DavidAnson/markdownlint/blob/v0.29.0/doc/md032.md
## Multi hop regions