Update ProtonVPN instructions to include recent addition of Wireguard #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…documentation (not necessary anymore)
qdm12
reviewed
Sep 14, 2024
| @@ -7,6 +7,6 @@ | |||
| | Variable | Default | Choices | Description | | |||
| | --- | --- | --- | --- | | |||
| | `VPN_PORT_FORWARDING` | `off` | `off` or `on` | Enable custom port forwarding code for supported providers | | |||
| | `VPN_PORT_FORWARDING_PROVIDER` | Current provider in use | `private internet access` or `protonvpn` | Choose the custom port forwarding code to use. This is useful when using the custom provider with Wireguard. For PIA, make sure you set `SERVER_NAMES=<server-name>`. | | |||
| | `VPN_PORT_FORWARDING_PROVIDER` | Current provider in use | `private internet access` | Choose the custom port forwarding code to use. This is useful when using the custom provider with Wireguard. For PIA, make sure you set `SERVER_NAMES=<server-name>`. | | |||
There was a problem hiding this comment.
Note to myself: add v4 comment to remove protonvpn as an option in the code
|
@qdm12 I integrated your remarks and fixed the linting errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ProtonVPN instructions to include recent addition of Wireguard support in qdm12/gluetun#2390
References to the custom provider have been removed as it is not necesary anymore.
This PR is mostly based on the comment of @TheRealBix (qdm12/gluetun#2390 (comment)) in the upstream PR.
I tested those instructions in my environment and can confirm they are complete.