Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate workflows to linux_job_v2 #6348

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Migrate workflows to linux_job_v2 #6348

merged 3 commits into from
Feb 28, 2025

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Feb 28, 2025 •
edited
Loading

  1. Migrate all the workflows to liux_job_v2 since its uses Manylinux 2.28 : RFC: [RFC] PyTorch next wheel build platform: manylinux-2.28 pytorch#123649
  2. Remove stronghold workflow, since not used
  3. Use get_stable_cuda_version to validate repacked binary size whls

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2025

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 28, 2025
malfet
malfet approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would be nice to explain why this migration is necessary

@seemethere
Copy link
Member

LGTM, but would be nice to explain why this migration is necessary

It's manylinux2_28 migration, might be helpful to just link the RFC issue from pytorch/pytorch for context

@atalman atalman merged commit 190c6f1 into pytorch:main Feb 28, 2025
54 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

@Camyll Camyll Camyll approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atalman @seemethere @malfet @Camyll @facebook-github-bot