Skip to content

Commit

Permalink
Migrate workflows to linux_job_v2 (#6348)
Browse files Browse the repository at this point in the history
1. Migrate all the workflows to liux_job_v2 since its uses Manylinux
2.28 : RFC: pytorch/pytorch#123649
2. Remove stronghold workflow, since not used
3. Use get_stable_cuda_version to validate repacked binary size whls
  • Loading branch information
atalman authored Feb 28, 2025
1 parent d43dd00 commit 190c6f1
Show file tree
Hide file tree
Showing 7 changed files with 14 additions and 103 deletions.
94 changes: 0 additions & 94 deletions .github/workflows/stronghold.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/test-export-matrix-variables.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
test-linux:
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
strategy:
fail-fast: false
matrix:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
test-tools:
name: Test tools
if: ${{ github.repository == 'pytorch/test-infra' }}
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
with:
docker-image: python:3.11.0-slim-bullseye
runner: linux.large
Expand All @@ -42,7 +42,7 @@ jobs:
test-github-scripts:
name: Test github scripts
if: ${{ github.repository == 'pytorch/test-infra' }}
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
with:
docker-image: python:3.11.0-slim-bullseye
runner: linux.large
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-aarch64-linux-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ jobs:
strategy:
matrix: ${{ fromJson(needs.generate-aarch64-linux-matrix.outputs.matrix) }}
fail-fast: false
uses: pytorch/test-infra/.github/workflows/linux_job.yml@main
uses: pytorch/test-infra/.github/workflows/linux_job_v2.yml@main
name: ${{ matrix.build_name }}
with:
runner: ${{ matrix.validation_runner }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-docker-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
strategy:
matrix: ${{ fromJson(needs.generate-matrix.outputs.matrix) }}
fail-fast: false
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
with:
runner: ${{ matrix.validation_runner }}
repository: "pytorch/pytorch"
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate-linux-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ jobs:
strategy:
matrix: ${{ fromJson(needs.generate-linux-matrix.outputs.matrix) }}
fail-fast: false
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
name: ${{ matrix.build_name }}
with:
runner: ${{ matrix.validation_runner }}
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
source ../../test-infra/.github/scripts/validate_binaries.sh
linux-amazon-2023:
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
name: amazon-linux-2023-test
with:
runner: "linux.g5.4xlarge.nvidia.gpu"
Expand Down
9 changes: 7 additions & 2 deletions .github/workflows/validate-repackaged-binary-sizes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
strategy:
matrix: ${{ fromJson(needs.generate-linux-matrix.outputs.matrix) }}
fail-fast: false
uses: ./.github/workflows/linux_job.yml
uses: ./.github/workflows/linux_job_v2.yml
name: ${{ matrix.build_name }}
with:
runner: ${{ matrix.validation_runner }}
Expand All @@ -45,8 +45,13 @@ jobs:
script: |
set -ex
# shellcheck disable=SC2086
CUDA_VERSION=$(python3 ../../test-infra/tools/scripts/get_stable_cuda_version.py --channel ${MATRIX_CHANNEL})
# shellcheck disable=SC2086
CUDA_VERSION_NODOT=$(echo ${CUDA_VERSION} | tr -d '.')
# skip testing on cu126
if [[ ${MATRIX_DESIRED_CUDA} == "cu126" ]]; then
if [[ ${MATRIX_DESIRED_CUDA} != "cu${CUDA_VERSION_NODOT}" ]]; then
exit 0
fi
Expand Down

0 comments on commit 190c6f1

Please sign in to comment.