Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support the upload of custom artifacts from artifacts-to-be-uploaded folder #5092

Merged
merged 2 commits into from
Apr 12, 2024
+18 −3
Merged

Support the upload of custom artifacts from artifacts-to-be-uploaded folder #5092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
32c2db2
Support the upload of custom artifacts from artifacts-to-be-uploaded dir
huydhn Apr 12, 2024
b2a6dc5
Also cover macos and windows jobs
huydhn Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/linux_job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ on:
default: "linux.2xlarge"
type: string
upload-artifact:
description: 'Name to give artifacts uploaded from ${RUNNER_ARTIFACT_DIR}'
description: |
Name to give artifacts uploaded from ${RUNNER_ARTIFACT_DIR}, all the wheel files
under dist/ and any files under artifacts-to-be-uploaded/ will be uploaded
default: ''
type: string
download-artifact:
Expand Down Expand Up @@ -269,6 +271,9 @@ jobs:
if find "dist/" -name "*.whl" >/dev/null 2>/dev/null; then
mv -v dist/*.whl "${RUNNER_ARTIFACT_DIR}/"
fi
if [[ -d "artifacts-to-be-uploaded" ]]; then
mv -v artifacts-to-be-uploaded/* "${RUNNER_ARTIFACT_DIR}/"
fi
# Set to fail upload step if there are no files for upload and expected files for upload
echo 'if-no-files-found=error' >> "${GITHUB_OUTPUT}"
fi
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/macos_job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ on:
default: "macos-12"
type: string
upload-artifact:
description: 'Name to give artifacts uploaded from ${RUNNER_ARTIFACT_DIR}'
description: |
Name to give artifacts uploaded from ${RUNNER_ARTIFACT_DIR}, all the wheel files
under dist/ and any files under artifacts-to-be-uploaded/ will be uploaded
default: ""
type: string
download-artifact:
Expand Down Expand Up @@ -175,6 +177,9 @@ jobs:
if find "dist/" -name "*.whl" >/dev/null 2>/dev/null; then
mv -v dist/*.whl "${RUNNER_ARTIFACT_DIR}/"
fi
if [[ -d "artifacts-to-be-uploaded" ]]; then
mv -v artifacts-to-be-uploaded/* "${RUNNER_ARTIFACT_DIR}/"
fi
# Set to fail upload step if there are no files for upload and expected files for upload
echo 'if-no-files-found=error' >> "${GITHUB_OUTPUT}"

Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/windows_job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@ on:
default: "windows.4xlarge"
type: string
upload-artifact:
description: 'Name to give artifacts uploaded from ${RUNNER_ARTIFACT_DIR}'
description: |
Name to give artifacts uploaded from ${RUNNER_ARTIFACT_DIR}, all the wheel files
under dist/ and any files under artifacts-to-be-uploaded/ will be uploaded
default: ''
type: string
download-artifact:
Expand Down Expand Up @@ -177,6 +179,9 @@ jobs:
if find "dist/" -name "*.whl" >/dev/null 2>/dev/null; then
mv -v dist/*.whl "${RUNNER_ARTIFACT_DIR}/"
fi
if [[ -d "artifacts-to-be-uploaded" ]]; then
mv -v artifacts-to-be-uploaded/* "${RUNNER_ARTIFACT_DIR}/"
fi
# Set to fail upload step if there are no files for upload and expected files for upload
echo 'if-no-files-found=error' >> "${GITHUB_OUTPUT}"

Expand Down
Loading